Re: [PATCH] drm/amdkfd: Replace kmalloc + copy_from_user with memdup_user

[Alex Deucher]

On Fri, Sep 12, 2025 at 8:48 AM Thorsten Blum <thorsten.b...@linux.dev> wrote:
>
> Hi Alex,
>
> On 9. Sep 2025, at 17:35, Alex Deucher wrote:
> > Applied.  Thanks!
> >
> > On Tue, Sep 9, 2025 at 11:29 AM Thorsten Blum <thorsten.b...@linux.dev> 
> > wrote:
> >>
> >> Replace kmalloc() followed by copy_from_user() with memdup_user() to
> >> improve and simplify kfd_criu_restore_queue().
> >>
> >> No functional changes intended.
> >>
> >> Signed-off-by: Thorsten Blum <thorsten.b...@linux.dev>
> >> ---
>
> I just learned that calling kfree() on an error pointer doesn't work, so
> this patch should probably be reverted/not applied.

Thanks for the heads up.

Alex