On 9/16/2025 7:25 PM, Xiangxu Yin wrote: > On 9/16/2025 6:22 PM, Dmitry Baryshkov wrote: >> On Tue, Sep 16, 2025 at 03:31:35PM +0800, Xiangxu Yin wrote: >>> Add DisplayPort controller binding for Qualcomm SM6150 SoC. >>> 'qcom,sm6150-dp' uses the same controller IP as 'qcom,sm8150-dp'. >>> Declare 'qcom,sm6150-dp' as a fallback compatible to 'qcom-sm8350-dp' >>> for consistency with existing bindings and to ensure correct matching and >>> future clarity. >>> >>> Signed-off-by: Xiangxu Yin <[email protected]> >>> --- >>> This series splits the SM6150 dp-controller definition from the >>> '[v3] Add DisplayPort support for QCS615 platform' series and rebases >>> 'dt-bindings: msm/dp: Add support for 4 pixel streams'. >>> >>> The devicetree modification for DisplayPort on SM6150 will be provided >>> in a future patch. >>> --- >>> Changes in v2: >>> - Update commit message and binding with fallback configuration. [Dmitry] >>> - Drop driver patch since SM6150 is declared as a fallback to >>> 'qcom-sm8350-dp'. >>> - Link to v1: >>> https://lore.kernel.org/r/20250912-add-dp-controller-support-for-sm6150-v1-0-02b34b7b7...@oss.qualcomm.com >>> --- >>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> index >>> aeb4e4f36044a0ff1e78ad47b867e232b21df509..82481519005a1b038a351aa358b9266239d0e8a9 >>> 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> @@ -46,6 +46,7 @@ properties: >>> - items: >>> - enum: >>> - qcom,sar2130p-dp >>> + - qcom,sm6150-dp >> In the review to the previos iteration I think I was a bit explicit: >> "qcom,sm6150-dp", "qcom,sm8150-dp", "qcom-sm8350-dp". You seemed to >> agree to it. Now you didn't implemet that. Why? > > Sorry, I misunderstood your previous comment. > I thought the recommendation was only about the commit message, not the > binding structure. > > Does the current implementation mean that qcom,sm6150-dp and qcom,sm8150-dp > fallback to "qcom,sm8350-dp"? > - items: > - enum: > - qcom,sar2130p-dp > - qcom,sm6150-dp > - qcom,sm7150-dp > - qcom,sm8150-dp > - qcom,sm8250-dp > - qcom,sm8450-dp > - qcom,sm8550-dp > - const: qcom,sm8350-dp > > Do you mean modifying it as below? > - items: > - enum: > - qcom,sar2130p-dp > - qcom,sm6150-dp > - qcom,sm7150-dp > - qcom,sm8250-dp > - qcom,sm8450-dp > - qcom,sm8550-dp > - const: qcom,sm8150-dp > - const: qcom,sm8350-dp >
Or this? - items: - enum: - qcom,sm6150-dp - const: qcom,sm8150-dp - const: qcom,sm8350-dp >>> - qcom,sm7150-dp >>> - qcom,sm8150-dp >>> - qcom,sm8250-dp >>> >>> --- >>> base-commit: c3067c2c38316c3ef013636c93daa285ee6aaa2e >>> change-id: 20250916-add-dp-controller-support-for-sm6150-525ac2ed8c86 >>> >>> Best regards, >>> -- >>> Xiangxu Yin <[email protected]> >>>
