Re: [PATCH] drm/tegra: hdmi: sor: Fix error: variable ‘j’ set but not used

[Mikko Perttunen]

On Tuesday, September 2, 2025 6:20 AM Brahmajit Das wrote:
> The variable j is set, however never used in or outside the loop, thus
> resulting in dead code.
> Building with GCC 16 results in a build error due to
> -Werror=unused-but-set-variable= enabled by default.
> This patch clean up the dead code and fixes the build error.
> 
> Example build log:
> drivers/gpu/drm/tegra/sor.c:1867:19: error: variable ‘j’ set but not used 
> [-Werror=unused-but-set-variable=]
>  1867 |         size_t i, j;
>       |                   ^
> 
> Signed-off-by: Brahmajit Das <list...@listout.xyz>
> ---
>  drivers/gpu/drm/tegra/hdmi.c | 4 ++--
>  drivers/gpu/drm/tegra/sor.c  | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
> index 8cd2969e7d4b..c4820f5e7658 100644
> --- a/drivers/gpu/drm/tegra/hdmi.c
> +++ b/drivers/gpu/drm/tegra/hdmi.c
> @@ -658,7 +658,7 @@ static void tegra_hdmi_write_infopack(struct tegra_hdmi 
> *hdmi, const void *data,
>  {
>       const u8 *ptr = data;
>       unsigned long offset;
> -     size_t i, j;
> +     size_t i;
>       u32 value;
>  
>       switch (ptr[0]) {
> @@ -691,7 +691,7 @@ static void tegra_hdmi_write_infopack(struct tegra_hdmi 
> *hdmi, const void *data,
>        * - subpack_low: bytes 0 - 3
>        * - subpack_high: bytes 4 - 6 (with byte 7 padded to 0x00)
>        */
> -     for (i = 3, j = 0; i < size; i += 7, j += 8) {
> +     for (i = 3; i < size; i += 7) {
>               size_t rem = size - i, num = min_t(size_t, rem, 4);
>  
>               value = tegra_hdmi_subpack(&ptr[i], num);
> diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
> index 21f3dfdcc5c9..bc7dd562cf6b 100644
> --- a/drivers/gpu/drm/tegra/sor.c
> +++ b/drivers/gpu/drm/tegra/sor.c
> @@ -1864,7 +1864,7 @@ static void tegra_sor_hdmi_write_infopack(struct 
> tegra_sor *sor,
>  {
>       const u8 *ptr = data;
>       unsigned long offset;
> -     size_t i, j;
> +     size_t i;
>       u32 value;
>  
>       switch (ptr[0]) {
> @@ -1897,7 +1897,7 @@ static void tegra_sor_hdmi_write_infopack(struct 
> tegra_sor *sor,
>        * - subpack_low: bytes 0 - 3
>        * - subpack_high: bytes 4 - 6 (with byte 7 padded to 0x00)
>        */
> -     for (i = 3, j = 0; i < size; i += 7, j += 8) {
> +     for (i = 3; i < size; i += 7) {
>               size_t rem = size - i, num = min_t(size_t, rem, 4);
>  
>               value = tegra_sor_hdmi_subpack(&ptr[i], num);
> 

Reviewed-by: Mikko Perttunen <mperttu...@nvidia.com>