Krzysztof,
On 8/21/25 3:43 AM, Krzysztof Kozlowski wrote:
On Wed, Aug 20, 2025 at 02:12:51PM -0300, Ariel D'Alessandro wrote:
Current, the DT bindings for MediaTek mmsys controller is missing the
assigned-clocks and assigned-clocks-rates properties. Add these and
No, they do not miss them. I don't understand why you are adding these.
The reason I added these is due to the following check error:
$ make -j$(nproc) CHECK_DTBS=y mediatek/mt8173-elm.dtb
DTC [C] arch/arm64/boot/dts/mediatek/mt8173-elm.dtb
[...]
arch/arm64/boot/dts/mediatek/mt8173-elm.dtb: syscon@14000000
(mediatek,mt8173-mmsys): 'assigned-clock-rates', 'assigned-clocks' do
not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id:
http://devicetree.org/schemas/arm/mediatek/mediatek,mmsys.yaml#
update the example as well.
Signed-off-by: Ariel D'Alessandro <[email protected]>
---
.../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
index 3f4262e93c789..d045d366eb8e2 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
@@ -68,6 +68,12 @@ properties:
of the power controller specified by phandle. See
Documentation/devicetree/bindings/power/power-domain.yaml for details.
+ assigned-clocks:
+ maxItems: 1
+
+ assigned-clock-rates:
+ maxItems: 1
+
Drop both, completely redundant and not actually in the scope of the binding.
Ack. Will fix accordingly in v2 based on the discussion above.
Thanks!
--
Ariel D'Alessandro
Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718
