From: Rajeev Tapadia <[email protected]> The mipi_dsi_dcs_write_buffer_chatty() helper is redundant and non-intuitive. It has been removed in favour of mipi_dsi_dcs_write_buffer_multi(), which handles multiple DSI writes with proper error accumulation.
Signed-off-by: Rajeev Tapadia <[email protected]> --- drivers/gpu/drm/drm_mipi_dsi.c | 32 ++------------------------------ include/drm/drm_mipi_dsi.h | 2 -- 2 files changed, 2 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index bc847ab5c822..c2fcc219cb58 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -926,40 +926,12 @@ ssize_t mipi_dsi_dcs_write_buffer(struct mipi_dsi_device *dsi, EXPORT_SYMBOL(mipi_dsi_dcs_write_buffer); /** - * mipi_dsi_dcs_write_buffer_chatty - mipi_dsi_dcs_write_buffer() w/ an error log - * @dsi: DSI peripheral device - * @data: buffer containing data to be transmitted - * @len: size of transmission buffer - * - * Like mipi_dsi_dcs_write_buffer() but includes a dev_err() - * call for you and returns 0 upon success, not the number of bytes sent. - * - * Return: 0 on success or a negative error code on failure. - */ -int mipi_dsi_dcs_write_buffer_chatty(struct mipi_dsi_device *dsi, - const void *data, size_t len) -{ - struct device *dev = &dsi->dev; - ssize_t ret; - - ret = mipi_dsi_dcs_write_buffer(dsi, data, len); - if (ret < 0) { - dev_err(dev, "sending dcs data %*ph failed: %zd\n", - (int)len, data, ret); - return ret; - } - - return 0; -} -EXPORT_SYMBOL(mipi_dsi_dcs_write_buffer_chatty); - -/** - * mipi_dsi_dcs_write_buffer_multi - mipi_dsi_dcs_write_buffer_chatty() w/ accum_err + * mipi_dsi_dcs_write_buffer_multi - mipi_dsi_dcs_write_buffer() w/ accum_err * @ctx: Context for multiple DSI transactions * @data: buffer containing data to be transmitted * @len: size of transmission buffer * - * Like mipi_dsi_dcs_write_buffer_chatty() but deals with errors in a way that + * Like mipi_dsi_dcs_write_buffer() but deals with errors in a way that * makes it convenient to make several calls in a row. */ void mipi_dsi_dcs_write_buffer_multi(struct mipi_dsi_multi_context *ctx, diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index e4d26ed7a62a..cda981a41bc6 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -326,8 +326,6 @@ enum mipi_dsi_dcs_tear_mode { ssize_t mipi_dsi_dcs_write_buffer(struct mipi_dsi_device *dsi, const void *data, size_t len); -int mipi_dsi_dcs_write_buffer_chatty(struct mipi_dsi_device *dsi, - const void *data, size_t len); void mipi_dsi_dcs_write_buffer_multi(struct mipi_dsi_multi_context *ctx, const void *data, size_t len); ssize_t mipi_dsi_dcs_write(struct mipi_dsi_device *dsi, u8 cmd, -- 2.51.0 Test patch
