On Wed, Sep 24, 2025 at 02:49:53PM +0800, Chu Guangqing wrote:
> Sorry, Thomas. The changes have been made this time.
>
> >Hi
> >
> >Am 10.09.25 um 04:23 schrieb Chu Guangqing:
> >> + select DRM_VRAM_HELPER
> >> + select DRM_TTM_HELPER
> >
> >I told you twice that VRAM helpers are obsolete and what to use instead.
> >
> It has been modified.
> >> +
> >> +struct yhgch_vdac {
> >> + struct drm_connector base;
> >> + struct i2c_adapter adapter;
> >> + struct i2c_algo_bit_data bit_data;
> >> +};
> >
> >I've asked you several times whether to adopt the coding style in
> >ast/mgag200 for the DDC.
> It has been modified.
> >
> >No only that you not respond to to any of my reviews, you keep on submitting
> >the same code again and again. Linux kernel development does not work like
> >that.
> >
> >NAK on this driver until you get your act together.
> >
> >Best regards
> >Thomas
> >
>
> to Dmitry:
> 1. use plane_state->dst instead of crtc_h/w/x/y.
> 2. delete duplicate framebuffer's atomic_check.
> 3. use FIELD_PREP() directly.
> 4. use dev->mode_config.
> 5. delete unnecessary drm_atomic_helper_shutdown call
> 6. add AUTHOR
> 7. using .enable instead
Please read Documentation/process/submitting-patches.rst.
>
> Chu Guangqing (1):
> [DRIVER] gpu: drm: add support for Yhgc ZX1000 soc chipset
>
> MAINTAINERS | 5 +
> drivers/gpu/drm/Kconfig | 2 +
> drivers/gpu/drm/Makefile | 1 +
> drivers/gpu/drm/yhgch/yhgch-drm/Kconfig | 11 +
> drivers/gpu/drm/yhgch/yhgch-drm/Makefile | 4 +
> .../gpu/drm/yhgch/yhgch-drm/yhgch_drm_de.c | 423 ++++++++++++++++++
> .../gpu/drm/yhgch/yhgch-drm/yhgch_drm_drv.c | 310 +++++++++++++
> .../gpu/drm/yhgch/yhgch-drm/yhgch_drm_drv.h | 51 +++
> .../gpu/drm/yhgch/yhgch-drm/yhgch_drm_i2c.c | 114 +++++
> .../gpu/drm/yhgch/yhgch-drm/yhgch_drm_regs.h | 208 +++++++++
> .../gpu/drm/yhgch/yhgch-drm/yhgch_drm_vdac.c | 123 +++++
> 11 files changed, 1252 insertions(+)
> create mode 100644 drivers/gpu/drm/yhgch/yhgch-drm/Kconfig
> create mode 100644 drivers/gpu/drm/yhgch/yhgch-drm/Makefile
> create mode 100644 drivers/gpu/drm/yhgch/yhgch-drm/yhgch_drm_de.c
> create mode 100644 drivers/gpu/drm/yhgch/yhgch-drm/yhgch_drm_drv.c
> create mode 100644 drivers/gpu/drm/yhgch/yhgch-drm/yhgch_drm_drv.h
> create mode 100644 drivers/gpu/drm/yhgch/yhgch-drm/yhgch_drm_i2c.c
> create mode 100644 drivers/gpu/drm/yhgch/yhgch-drm/yhgch_drm_regs.h
> create mode 100644 drivers/gpu/drm/yhgch/yhgch-drm/yhgch_drm_vdac.c
>
> --
> 2.43.5
>
--
With best wishes
Dmitry
