Hi Daniel, On 2025-09-25 at 14:42:44 +0200, Daniel Almeida wrote: > Hi Kamil, > > > On 16 Sep 2025, at 14:12, Kamil Konieczny <[email protected]> > > wrote: > > > > Hi Daniel, > > On 2025-09-12 at 15:19:29 -0300, Daniel Almeida wrote: > >> Add the necessary code needed to compile panthor tests as well as the > >> basic infrastructure that will be used by the Panthor tests themselves. > >> > >> To make sure everything is in order, add a basic test in > >> panthor_query.c. > >> > >> Signed-off-by: Daniel Almeida <[email protected]> > >> --- > >> lib/igt_panthor.c | 41 +++++++++++++++++++++++++++++++++++ > >> lib/igt_panthor.h | 12 ++++++++++ > >> lib/meson.build | 1 + > >> meson.build | 8 +++++++ > >> tests/meson.build | 2 ++ > >> tests/panthor/meson.build | 12 ++++++++++ > >> tests/panthor/panthor_query.c | 25 +++++++++++++++++++++ > >> 7 files changed, 101 insertions(+) > >> create mode 100644 lib/igt_panthor.c > >> create mode 100644 lib/igt_panthor.h > >> create mode 100644 tests/panthor/meson.build > >> create mode 100644 tests/panthor/panthor_query.c > >> > >> diff --git a/lib/igt_panthor.c b/lib/igt_panthor.c > >> new file mode 100644 > >> index 000000000..0b690f796 > >> --- /dev/null > >> +++ b/lib/igt_panthor.c > >> @@ -0,0 +1,41 @@ > >> +// SPDX-License-Identifier: MIT > >> +// SPDX-FileCopyrightText: Copyright (C) 2025 Collabora Ltd. > > > > We use SPD for licence because they are long texts. I do not > > see any benefit of SPDX for copyright lines, it makes it even > > longer than needed. It could stay if you want. > > > > Acked-by: Kamil Konieczny <[email protected]> > > > > Regards, > > Kamil > > > > I’d rather keep it. I tend to favor standardization and having a standard > way to declare copyrights seems beneficial to me. What are the next steps > here? > Should I send a new version to pickup the tags, or can this be merged already? > > Same for the other patch. > > — Daniel > > Will anyone familiar with Pathor do a full review or are you ok with only my ack? If ack + tested-by is ok I could merge it.
Regards, Kamil
