On 9/30/2025 12:39 PM, Dmitry Baryshkov wrote: > On Tue, Sep 30, 2025 at 11:18:11AM +0530, Akhil P Oommen wrote: >> In A6x family (which is a pretty big one), there are separate >> adreno_func definitions for each sub-generations. To streamline the >> identification of the correct struct for a gpu, move it to the >> catalogue and move the gpu_init routine to struct adreno_gpu_funcs. >> >> Signed-off-by: Akhil P Oommen <[email protected]> >> --- >> drivers/gpu/drm/msm/adreno/a2xx_catalog.c | 8 +- >> drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 50 +++---- >> drivers/gpu/drm/msm/adreno/a3xx_catalog.c | 14 +- >> drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 52 +++---- >> drivers/gpu/drm/msm/adreno/a4xx_catalog.c | 8 +- >> drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 54 ++++---- >> drivers/gpu/drm/msm/adreno/a5xx_catalog.c | 18 +-- >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 61 ++++----- >> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 50 +++---- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 209 >> ++++++++++++++--------------- >> drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +- >> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 11 +- >> 12 files changed, 275 insertions(+), 262 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a2xx_catalog.c >> b/drivers/gpu/drm/msm/adreno/a2xx_catalog.c >> index >> 5ddd015f930d9a7dd04e2d2035daa0b2f5ff3f27..af3e4cceadd11d4e0ec4ba75f75e405af276cb7e >> 100644 >> --- a/drivers/gpu/drm/msm/adreno/a2xx_catalog.c >> +++ b/drivers/gpu/drm/msm/adreno/a2xx_catalog.c >> @@ -8,6 +8,8 @@ >> >> #include "adreno_gpu.h" >> >> +extern const struct adreno_gpu_funcs a2xx_gpu_funcs; > > Please move these definitions to aNxx_gpu.h (a2xx_gpu.h, etc). LGTM > otherwise.
This is a special case. These symbols needs to be visible only here. -Akhil >
