On Thu, February 24, 2011 20:04, Alex Riesen wrote: > On Thu, Feb 24, 2011 at 10:18, Indan Zupancic <indan at nul.nu> wrote: >>>> >>>> As it turns out this is a bug in the userspace components of the stack for >>>> gen2 hardware, with lax kernel side enforcement. Daniel has a fix for both. >>> >>> Chris, could you point us at the patch? I ask because Daniel left a >>> comment in bug discussion that we should ignore some patch from him, >>> and there was no mention of anything else. >>> >>> I'll gladly test a better fix. >> >> See: >> >> http://lists.freedesktop.org/archives/dri-devel/2011-February/008658.html > > This is precisely the link on which Daniel commented: [...] > And yes, it does not help at all to fix the corruption in the ticket.
Because there are two (or three) corruption problems! One is fixed by Daniels's patch, the other isn't fixed yet AFAIC. You're grumbling that I'm giving you information about the fix for one problem, the one Chris was talking about and you replied to, while you're interested in the other one (or both). >> https://lkml.org/lkml/2011/2/23/34 > > This is just the discussion about the problem described in the ticket. > It does not even mention the patch from the previous link, BTW. > It does have the patch which returns -EINVAL for > I915_PARAM_HAS_RELAXED_FENCING, > though. > > So, AFAICS, at the moment there is no better patch than this: > > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > index 17bd766..8f8a6a3 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -764,7 +764,7 @@ static int i915_getparam(struct drm_device *dev, void > *data, > break; > case I915_PARAM_HAS_RELAXED_FENCING: > value = 1; > - break; > + return -EINVAL; > case I915_PARAM_HAS_COHERENT_RINGS: > value = 1; > break; Read those above links again! Daniel's patch fixes that one corruption, the above snippet has the same effect and works around the same bug, but neither do fix that other corruption mentioned in the ticket. Greetings, Indan
