Reviewed-by: Lyude Paul <[email protected]>
On Mon, 2025-12-08 at 18:26 +0900, Alexandre Courbot wrote:
> `run` doesn't require a bound device as its argument.
>
> Signed-off-by: Alexandre Courbot <[email protected]>
> ---
> drivers/gpu/nova-core/firmware/fwsec.rs | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/nova-core/firmware/fwsec.rs
> b/drivers/gpu/nova-core/firmware/fwsec.rs
> index b28e34d279f4..b98b1286dc94 100644
> --- a/drivers/gpu/nova-core/firmware/fwsec.rs
> +++ b/drivers/gpu/nova-core/firmware/fwsec.rs
> @@ -412,12 +412,7 @@ pub(crate) fn new(
> }
>
> /// Loads the FWSEC firmware into `falcon` and execute it.
> - pub(crate) fn run(
> - &self,
> - dev: &Device<device::Bound>,
> - falcon: &Falcon<Gsp>,
> - bar: &Bar0,
> - ) -> Result<()> {
> + pub(crate) fn run(&self, dev: &Device, falcon: &Falcon<Gsp>,
> bar: &Bar0) -> Result<()> {
> // Reset falcon, load the firmware, and run it.
> falcon
> .reset(bar)
