Hi, On Sat, Dec 13, 2025 at 6:24 AM Amin GATTOUT <[email protected]> wrote: > > Update the driver to use the non-deprecated mipi_dsi_*_multi() > helpers, as recommended in Documentation/gpu/todo.rst. The multi > variants provide proper error accumulation and handle the required > DCS NOP insertions, which suits the OTM8009A command sequences. > > Refactor otm8009a_dcs_write_buf() and the dcs_write_seq/dcs_write_cmd_at > macros to take a mipi_dsi_multi_context pointer, passing it through > from callers. This ensures consistent error handling throughout the > driver. > > Replace all mdelay() and msleep() calls within DSI command sequences > with mipi_dsi_msleep() for proper error accumulation. > > The init, disable, and backlight update paths now return dsi_ctx.accum_err, > ensuring errors are propagated to callers. > > Signed-off-by: Amin GATTOUT <[email protected]> > --- > .../gpu/drm/panel/panel-orisetech-otm8009a.c | 183 +++++++----------- > 1 file changed, 74 insertions(+), 109 deletions(-)
No need to resend, but for future reference you should be including version history "after the cut" when you send new versions. If you're using a tool like b4 or patman to help send the patches, both should make it easy to do this. In any case, this looks nice to me! Always good to see the code get more readable and smaller at the same time (35 lines of code less!). ...and even handle errors more properly now! "scripts/bloat-o-meter" shows that, while we don't save tons of bytes like we did on drivers that used to actually do error checking, we still save a little (1.5%): add/remove: 0/2 grow/shrink: 2/6 up/down: 56/-416 (-360) Function old new delta otm8009a_disable 156 204 +48 otm8009a_backlight_update_status 204 212 +8 .Ltmp9 8 - -8 otm8009a_prepare 2128 2100 -28 $d 3364 3324 -40 .Ltmp3 3092 3028 -64 .Ltmp2 3164 3100 -64 .Ltmp1 3620 3556 -64 $x 3720 3656 -64 otm8009a_dcs_write_buf 84 - -84 Total: Before=23340, After=22980, chg -1.54% Reviewed-by: Douglas Anderson <[email protected]> I was thinking of landing this mid way through this week unless anyone has any objections. -Doug
