On Thu, Dec 18, 2025 at 11:31:40PM +0100, Vincent Mailhol wrote: > Hi Dan, > > On 18/12/2025 at 20:36, Dan Carpenter wrote: > > On Thu, Dec 18, 2025 at 07:50:01PM +0100, Vincent Mailhol wrote: > > (...) > > >> With this, remove gcc's -Wtype-limits. People who still want to catch > >> incorrect comparisons between unsigned integers and zero can now use > >> sparse instead. > >> > >> On a side note, clang also has a -Wtype-limits warning but: > >> > >> * it is not enabled in the kernel at the moment because, contrary to > >> gcc, clang did not include it under -Wextra. > >> > >> * it does not warn if the code results from a macro expansion. So, > >> if activated, it would not cause as much spam as gcc does. > >> > >> * -Wtype-limits is split into four sub-warnings [3] meaning that if > >> it were to be activated, we could select which one to keep. > >> > > > > Sounds good. I like your Sparse check. > > Does it mean I have your Reviewed-by? > > > Maybe we should enable the Sparse checking as well because it sounds > > like they are doing a lot of things right. > > I am not sure to understand what do you mean by "enable the Sparse checking"?
I meant Clang... Sorry. Doh. regards, dan carpenter
