On Mon, Dec 22, 2025 at 06:50:05PM +0100, Michal Wajdeczko wrote:
> On some configs and old compilers we can get following build errors:
>
> ../drivers/gpu/drm/xe/xe_configfs.h: In function
> 'xe_configfs_get_ctx_restore_mid_bb':
> ../drivers/gpu/drm/xe/xe_configfs.h:40:76: error: parameter name omitted
> static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev,
> enum xe_engine_class,
>
> ^~~~~~~~~~~~~~~~~~~~
> ../drivers/gpu/drm/xe/xe_configfs.h: In function
> 'xe_configfs_get_ctx_restore_post_bb':
> ../drivers/gpu/drm/xe/xe_configfs.h:42:77: error: parameter name omitted
> static inline u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev
> *pdev, enum xe_engine_class,
>
> ^~~~~~~~~~~~~~~~~~~~
> when trying to define our configfs stub functions. Fix that.
>
> Fixes: 7a4756b2fd04 ("drm/xe/lrc: Allow to add user commands mid context
> switch")
> Signed-off-by: Michal Wajdeczko <[email protected]>
> Cc: Rodrigo Vivi <[email protected]>
> ---
> drivers/gpu/drm/xe/xe_configfs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_configfs.h
> b/drivers/gpu/drm/xe/xe_configfs.h
> index fed57be0b90e..9998ec7c9956 100644
> --- a/drivers/gpu/drm/xe/xe_configfs.h
> +++ b/drivers/gpu/drm/xe/xe_configfs.h
> @@ -37,9 +37,9 @@ static inline bool xe_configfs_primary_gt_allowed(struct
> pci_dev *pdev) { return
> static inline bool xe_configfs_media_gt_allowed(struct pci_dev *pdev) {
> return true; }
> static inline u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev) {
> return U64_MAX; }
> static inline bool xe_configfs_get_psmi_enabled(struct pci_dev *pdev) {
> return false; }
> -static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev,
> enum xe_engine_class,
> +static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev,
> enum xe_engine_class c,
> const u32 **cs) { return
> 0; }
> -static inline u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev,
> enum xe_engine_class,
> +static inline u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev,
> enum xe_engine_class c,
> const u32 **cs) { return
> 0; }
Let's align everything with the .c signatures:
bool xe_configfs_get_psmi_enabled(struct pci_dev *pdev);
-u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev, enum
xe_engine_class,
+u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev,
+ enum xe_engine_class class,
const u32 **cs);
-u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev, enum
xe_engine_class,
+u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev,
+ enum xe_engine_class class,
const u32 **cs);
#ifdef CONFIG_PCI_IOV
unsigned int xe_configfs_get_max_vfs(struct pci_dev *pdev);
@@ -37,9 +39,11 @@ static inline bool xe_configfs_primary_gt_allowed(struct
pci_dev *pdev) { return
static inline bool xe_configfs_media_gt_allowed(struct pci_dev *pdev) { return
true; }
static inline u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev) {
return U64_MAX; }
static inline bool xe_configfs_get_psmi_enabled(struct pci_dev *pdev) { return
false; }
-static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev,
enum xe_engine_class,
+static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev,
+ enum xe_engine_class class,
const u32 **cs) { return
0; }
-static inline u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev,
enum xe_engine_class,
+static inline u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev,
+ enum xe_engine_class
class,
const u32 **cs) { return
0; }
> static inline unsigned int xe_configfs_get_max_vfs(struct pci_dev *pdev) {
> return UINT_MAX; }
> #endif
> --
> 2.47.1
>
