When drm_bridge_attach() fails, the function should return an error
instead of continuing execution.

Signed-off-by: Osama Abdelkader <[email protected]>
---
 drivers/gpu/drm/bridge/synopsys/dw-dp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c 
b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
index 82aaf74e1bc0..b6fe313ccaf8 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
@@ -2062,8 +2062,10 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct 
drm_encoder *encoder,
        }
 
        ret = drm_bridge_attach(encoder, bridge, NULL, 
DRM_BRIDGE_ATTACH_NO_CONNECTOR);
-       if (ret)
+       if (ret) {
                dev_err_probe(dev, ret, "Failed to attach bridge\n");
+               return ERR_PTR(ret);
+       }
 
        dw_dp_init_hw(dp);
 
-- 
2.43.0

Reply via email to