On Thu, Dec 25, 2025 at 12:09:29PM -0500, Yury Norov (NVIDIA) wrote: > The trace_printk.h header is debugging-only by nature, but now it's > included by almost every compilation unit via kernel.h. > > Removing trace_printk.h saves 1.5-2% of compilation time on my > Ubuntu-derived x86_64/localyesconfig. > > There's ~30 files in the codebase, requiring trace_printk.h for > non-debugging reasons: mostly to disable tracing on panic or under > similar conditions. Include the header for those explicitly. > > This implicitly decouples linux/kernel.h and linux/instruction_pointer.h > as well, because it has been isolated to trace_printk.h early in the > series.
... > #include <linux/pagevec.h> > #include <linux/scatterlist.h> > #include <linux/workqueue.h> > +#include <linux/trace_printk.h> I believe 't' is followed by 'w' and not vise versa. ... > index 20b3cb29cfff..549fdeaf4508 100644 > --- a/drivers/gpu/drm/i915/i915_gem.h > +++ b/drivers/gpu/drm/i915/i915_gem.h > @@ -27,6 +27,7 @@ > > #include <linux/bug.h> > #include <linux/types.h> > +#include <linux/trace_printk.h> In the similar way 'r' then 'y'. ... Please, double check these and the rest. -- With Best Regards, Andy Shevchenko
