On Sat, Jan 10, 2026 at 06:23:59PM -0800, Rob Clark wrote: > On Sat, Jan 10, 2026 at 6:17 PM Dmitry Baryshkov > <[email protected]> wrote: > > > > On Fri, Jan 09, 2026 at 07:37:29AM -0800, Rob Clark wrote: > > > This should also be zero for gen8. > > > > > > Fixes: 288a93200892 ("drm/msm/adreno: Introduce A8x GPU Support") > > > Signed-off-by: Rob Clark <[email protected]> > > > --- > > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > > > b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > > > index 1c80909e63ca..d5fe6f6f0dec 100644 > > > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > > > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > > > @@ -376,8 +376,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct > > > msm_context *ctx, > > > *value = adreno_gpu->info->gmem; > > > return 0; > > > case MSM_PARAM_GMEM_BASE: > > > - if (adreno_is_a650_family(adreno_gpu) || > > > - adreno_is_a740_family(adreno_gpu)) > > > + if (adreno_gpu->info->family >= ADRENO_6XX_GEN4) > > > > What about a7xx gen1? should it also be 0? > > *probably*.. I'm guessing this was incorrect before
I'd at least mention it in the commit message. > > BR, > -R > > > > > > *value = 0; > > > else > > > *value = 0x100000; > > > -- > > > 2.52.0 > > > > > > > -- > > With best wishes > > Dmitry -- With best wishes Dmitry
