>>> >>> Is there any reason why you replace the UPPERCASE register names with >>> CamelCase ones? >>> >>> I was under the impression that we want to use UPPERCASE for register >>> names. Like in nova >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/nova-core/regs.rs >> >> Not really. UPPERCASE for non-const items will trigger the linter. The Nova >> people chose to #[allow] this to align with OpenRM and, IIRC from the LPC >> discussions, their registers are automatically generated from some internal >> docs. >> >> We have only a few, we can simply convert them to CamelCase. > > Frankly, register names do look nicer in UPPER_CASE, especially that they're > in > many cases, packed with acronyms. > > Best, > Gary >
I don’t have an opinion here, to be honest. I think CamelCase does make it easier on the eyes since our register names look quite simple, specially when compared to Nova. However, I can switch to UPPER_CASE and add an #![allow(non_camel_case_types)] if more people chime in.
