On Fri, Jan 16, 2026 at 10:27:56AM -0500, Alex Deucher wrote: > On Fri, Jan 16, 2026 at 10:12 AM Linus Heckemann <[email protected]> wrote: > > > > Jason Gunthorpe <[email protected]> writes: > > > > > On Thu, Dec 25, 2025 at 10:05:59PM +0100, Linus Heckemann wrote: > > >> It appears the code removed here was not in fact entirely dead; my 2024 > > >> gpd win mini ("G1617-01", with a Ryzen 8840U) fails to suspend > > >> correctly, and I bisected the issue to this commit. > > > > > > The only behavior change this patch had that could be relavent to a > > > Ryzen was in drivers/accel/amdxdna/aie2_pci.c - are you using this > > > driver? > > > > > > Prior to this patch amdxdna would have failed to load in configs > > > without an iommu as iommu_dev_enable_feature() would have > > > failed. After this patch it will load successfully. > > > > > > If so then that driver presmuably doesn't have working power > > > management in your system. > > > > You're right, blacklisting the amdxdna driver fixes suspend, thanks for > > the pointer! > > > > @Min Ma, Lizhi Hou, dri-devel: do you have any insight into why this > > might be happening? > > The xdna driver requires SVA and the IOMMU.
It should probably call device_iommu_mapped() during probe then Jason
