mcde_dsi_bind() has a loop over all subnodes looking for a panel, but does not exit when a match is found and only stores the last match. However this will be problematic when introducing refcounting on the struct drm_device pointer in a following commit, because of_drm_find_and_get_bridge() would get a reference to multiple bridges.
Assuming there is no real reason for looking for multiple panels, add a warning so it gets noticed in case the assumption is wrong. Signed-off-by: Luca Ceresoli <[email protected]> --- I think the correct thing to do would be adding a break statement when there is a match. However I don't have knowledge of this driver and the hardware, thus this patch is a prudential alternative, not changing the behaviour. --- drivers/gpu/drm/mcde/mcde_dsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c index a3423459dd7a..3faebe571fc2 100644 --- a/drivers/gpu/drm/mcde/mcde_dsi.c +++ b/drivers/gpu/drm/mcde/mcde_dsi.c @@ -1103,6 +1103,9 @@ static int mcde_dsi_bind(struct device *dev, struct device *master, /* Look for a panel as a child to this node */ for_each_available_child_of_node(dev->of_node, child) { + /* There should be only one panel subnode */ + WARN_ON(panel || bridge); + panel = of_drm_find_panel(child); if (IS_ERR(panel)) { dev_err(dev, "failed to find panel try bridge (%ld)\n", -- 2.52.0
