On Tue Dec 16, 2025 at 5:27 AM CET, Alexandre Courbot wrote:
> /// Loads the FWSEC firmware into `falcon` and execute it.
> - pub(crate) fn run(
> - &self,
> - dev: &Device<device::Bound>,
> - falcon: &Falcon<Gsp>,
> - bar: &Bar0,
Hm..the method also takes a &pci::Bar, so its either called from a bound context
or within a Revocable critical section.
Leaving the other argument as &Device<Bound> makes it obvious which one it is
(and should be).
> - ) -> Result<()> {
> + pub(crate) fn run(&self, dev: &Device, falcon: &Falcon<Gsp>, bar: &Bar0)
> -> Result<()> {
> // Reset falcon, load the firmware, and run it.
> falcon
> .reset(bar)
>
> --
> 2.52.0
