Re: [PATCH v3 3/6] drm/sun4i: Enable LVDS output on sun20i D1s/T113

[Parthiban]

Dear Kuba,

On 11/16/25 2:48 PM, Kuba Szczodrzyński wrote:
> +static void sun20i_tcon_setup_lvds_dphy(struct sun4i_tcon *tcon,
> +                                     const struct drm_encoder *encoder)
> +{
> +     union phy_configure_opts opts = { };
> +
> +     if (!tcon->quirks->has_combo_dphy || !tcon->dphy)
> +             return;
> +
> +     if (phy_init(tcon->dphy))
> +             return;
> +
> +     if (phy_set_mode(tcon->dphy, PHY_MODE_LVDS))

>From Documentation/driver-api/phy/phy.rst, set_mode shall be after power_on. 
>But re-order
will fail to work for our case. Not sure if this is fine.

Thanks,
Parthiban

> +             return;
> +
> +     if (phy_configure(tcon->dphy, &opts))
> +             return;
> +
> +     if (phy_power_on(tcon->dphy))
> +             return;