This series fixes a few bugs in the GSP command queue ring buffer implementation in nova-core and also clarifies some of the comments.
The ring buffer uses read and write pointers (rx/tx) to track which areas are available for the CPU vs the GSP to read/write into. In the ring buffers there were some indexing issues which could end up causing panics, so I fixed those and added more rigorous proofs of correctness in the panic comments. Signed-off-by: Eliot Courtney <[email protected]> --- Changes in v2: - Modified PANIC comments to match existing style. - Link to v1: https://lore.kernel.org/r/[email protected] --- Eliot Courtney (4): gpu: nova-core: gsp: fix incorrect advancing of write pointer gpu: nova-core: gsp: clarify comments about invariants and pointer roles gpu: nova-core: gsp: fix improper handling of empty slot in cmdq gpu: nova-core: gsp: fix improper indexing in driver_read_area drivers/gpu/nova-core/gsp/cmdq.rs | 72 ++++++++++++++++++++++++--------------- 1 file changed, 44 insertions(+), 28 deletions(-) --- base-commit: 6ea52b6d8f33ae627f4dcf43b12b6e713a8b9331 change-id: 20260121-nova-core-cmdq1-6aaa369824c4 Best regards, -- Eliot Courtney <[email protected]>
