On 16/01/2026 17:19, Maíra Canal wrote:
If PIXEL_CLK or HEVC_CLK is disabled during boot, the firmware will skip
HSM initialization, which would result in a bus lockup. However, those
clocks are consumed by drivers (vc4 and HEVC decoder drivers,
respectively), which means that they can be enabled/disabled by the
drivers.

Mark those clocks as CLK_IGNORE_UNUSED to allow them to be disabled by
drivers when appropriate.
Acked-by: Melissa Wen <[email protected]>

But it'd be better if Stefan or Dave could check if we're missing anything in the firmware perspective.

Signed-off-by: Maíra Canal <[email protected]>
---
  drivers/clk/bcm/clk-raspberrypi.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/bcm/clk-raspberrypi.c 
b/drivers/clk/bcm/clk-raspberrypi.c
index 
9783385d5859836898683209e320fcc928dfdc71..41f058bf44e8a5257e4b2a90389b5e9525f2fffb
 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -139,12 +139,12 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
        [RPI_FIRMWARE_PIXEL_CLK_ID] = {
                .export = true,
                .minimize = true,
-               .flags = CLK_IS_CRITICAL,
+               .flags = CLK_IGNORE_UNUSED,
        },
        [RPI_FIRMWARE_HEVC_CLK_ID] = {
                .export = true,
                .minimize = true,
-               .flags = CLK_IS_CRITICAL,
+               .flags = CLK_IGNORE_UNUSED,
        },
        [RPI_FIRMWARE_ISP_CLK_ID] = {
                .export = true,


Reply via email to