On Mon, Jan 19, 2026 at 09:30:26AM +0530, Riana Tauro wrote:
Report the SOC nonfatal/fatal hardware error and update the counters.
Co-developed-by: Himal Prasad Ghimiray <[email protected]>
Signed-off-by: Himal Prasad Ghimiray <[email protected]>
Signed-off-by: Riana Tauro <[email protected]>
---
v2: Add ID's and names as uAPI (Rodrigo)
v3: reorder and align arrays
remove redundant string err
use REG_BIT
fix aesthic review comments (Raag)
use only correctable/uncorrectable error severity (Aravind)
---
drivers/gpu/drm/xe/regs/xe_hw_error_regs.h | 24 +++
drivers/gpu/drm/xe/xe_hw_error.c | 200 ++++++++++++++++++++-
2 files changed, 223 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/regs/xe_hw_error_regs.h
b/drivers/gpu/drm/xe/regs/xe_hw_error_regs.h
index 5eeb0be27300..b9e072f9e56c 100644
--- a/drivers/gpu/drm/xe/regs/xe_hw_error_regs.h
+++ b/drivers/gpu/drm/xe/regs/xe_hw_error_regs.h
@@ -41,6 +41,7 @@
DEV_ERR_STAT_NONFATAL))
#define XE_CSC_ERROR 17
+#define XE_SOC_ERROR 16
#define XE_GT_ERROR 0
#define ERR_STAT_GT_FATAL_VECTOR_0 0x100260
@@ -62,4 +63,27 @@
ERR_STAT_GT_COR_VECTOR_REG(x) :
\
ERR_STAT_GT_FATAL_VECTOR_REG(x))
+#define SOC_PVC_MASTER_BASE 0x282000
+#define SOC_PVC_SLAVE_BASE 0x283000
+
+#define SOC_GCOERRSTS 0x200
+#define SOC_GNFERRSTS 0x210
+#define SOC_GLOBAL_ERR_STAT_REG(base, x) XE_REG(_PICK_EVEN((x), \
+ (base) +
SOC_GCOERRSTS, \
+ (base) +
SOC_GNFERRSTS))
+#define SOC_SLAVE_IEH REG_BIT(1)
+#define SOC_IEH0_LOCAL_ERR_STATUS REG_BIT(0)
+#define SOC_IEH1_LOCAL_ERR_STATUS REG_BIT(0)
+
+#define SOC_GSYSEVTCTL 0x264
+#define SOC_GSYSEVTCTL_REG(base, slave_base, x) XE_REG(_PICK_EVEN((x), \
Can we add 'master' for consistency? This gets me confused with
other macros where 'base' can mean either one.
#endif
diff --git a/drivers/gpu/drm/xe/xe_hw_error.c b/drivers/gpu/drm/xe/xe_hw_error.c
index bd0cf61741ca..d1c30bb199d3 100644
--- a/drivers/gpu/drm/xe/xe_hw_error.c
+++ b/drivers/gpu/drm/xe/xe_hw_error.c
@@ -19,6 +19,7 @@
#define GT_HW_ERROR_MAX_ERR_BITS 16
#define HEC_UNCORR_FW_ERR_BITS 4
#define XE_RAS_REG_SIZE 32
+#define XE_SOC_NUM_IEH 2
extern struct fault_attr inject_csc_hw_error;
static const char * const error_severity[] = DRM_XE_RAS_ERROR_SEVERITY_NAMES;
@@ -31,7 +32,8 @@ static const char * const hec_uncorrected_fw_errors[] = {
};
static const unsigned long xe_hw_error_map[] = {
- [XE_GT_ERROR] = DRM_XE_RAS_ERROR_CLASS_GT,
+ [XE_GT_ERROR] = DRM_XE_RAS_ERROR_CLASS_GT,
+ [XE_SOC_ERROR] = DRM_XE_RAS_ERROR_CLASS_SOC,
};
enum gt_vector_regs {
@@ -54,6 +56,92 @@ static enum drm_xe_ras_error_severity
hw_err_to_severity(enum hardware_error hw_
return DRM_XE_RAS_ERROR_SEVERITY_UNCORRECTABLE;
}
+static const char * const pvc_master_global_err_reg[] = {
+ [0 ... 1] = "Undefined",
+ [2] = "HBM SS0: Channel0",
+ [3] = "HBM SS0: Channel1",
+ [4] = "HBM SS0: Channel2",
+ [5] = "HBM SS0: Channel3",
+ [6] = "HBM SS0: Channel4",
+ [7] = "HBM SS0: Channel5",
+ [8] = "HBM SS0: Channel6",
+ [9] = "HBM SS0: Channel7",
+ [10] = "HBM SS1: Channel0",
+ [11] = "HBM SS1: Channel1",
+ [12] = "HBM SS1: Channel2",
+ [13] = "HBM SS1: Channel3",
+ [14] = "HBM SS1: Channel4",
+ [15] = "HBM SS1: Channel5",
+ [16] = "HBM SS1: Channel6",
+ [17] = "HBM SS1: Channel7",
+ [18 ... 31] = "Undefined",
+};
I'd add static_assert() against register size here.
+static const char * const pvc_slave_global_err_reg[] = {
+ [0] = "Undefined",
+ [1] = "HBM SS2: Channel0",
+ [2] = "HBM SS2: Channel1",
+ [3] = "HBM SS2: Channel2",
+ [4] = "HBM SS2: Channel3",
+ [5] = "HBM SS2: Channel4",
+ [6] = "HBM SS2: Channel5",
+ [7] = "HBM SS2: Channel6",
+ [8] = "HBM SS2: Channel7",
+ [9] = "HBM SS3: Channel0",
+ [10] = "HBM SS3: Channel1",
+ [11] = "HBM SS3: Channel2",
+ [12] = "HBM SS3: Channel3",
+ [13] = "HBM SS3: Channel4",
+ [14] = "HBM SS3: Channel5",
+ [15] = "HBM SS3: Channel6",
+ [16] = "HBM SS3: Channel7",
+ [17] = "Undefined",
+ [18] = "ANR MDFI",
+ [19 ... 31] = "Undefined",
+};
Ditto.
+static const char * const pvc_slave_local_fatal_err_reg[] = {
+ [0] = "Local IEH: Malformed PCIe AER",
+ [1] = "Local IEH: Malformed PCIe ERR",
+ [2] = "Local IEH: UR conditions in IEH",
+ [3] = "Local IEH: From SERR Sources",
+ [4 ... 19] = "Undefined",
+ [20] = "Malformed MCA error packet (HBM/Punit)",
+ [21 ... 31] = "Undefined",
+};
Ditto.
+static const char * const pvc_master_local_fatal_err_reg[] = {
+ [0] = "Local IEH: Malformed IOSF PCIe AER",
+ [1] = "Local IEH: Malformed IOSF PCIe ERR",
+ [2] = "Local IEH: UR RESPONSE",
+ [3] = "Local IEH: From SERR SPI controller",
+ [4] = "Base Die MDFI T2T",
+ [5] = "Undefined",
+ [6] = "Base Die MDFI T2C",
+ [7] = "Undefined",
+ [8] = "Invalid CSC PSF Command Parity",
+ [9] = "Invalid CSC PSF Unexpected Completion",
+ [10] = "Invalid CSC PSF Unsupported Request",
+ [11] = "Invalid PCIe PSF Command Parity",
+ [12] = "PCIe PSF Unexpected Completion",
+ [13] = "PCIe PSF Unsupported Request",
+ [14 ... 19] = "Undefined",
+ [20] = "Malformed MCA error packet (HBM/Punit)",
+ [21 ... 31] = "Undefined",
+};
Ditto.
+static const char * const pvc_master_local_nonfatal_err_reg[] = {
+ [0 ... 3] = "Undefined",
+ [4] = "Base Die MDFI T2T",
+ [5] = "Undefined",
+ [6] = "Base Die MDFI T2C",
+ [7] = "Undefined",
+ [8] = "Invalid CSC PSF Command Parity",
+ [9] = "Invalid CSC PSF Unexpected Completion",
+ [10] = "Invalid PCIe PSF Command Parity",
+ [11 ... 31] = "Undefined",
+};
Ditto.
static bool fault_inject_csc_hw_error(void)
{
return IS_ENABLED(CONFIG_DEBUG_FS) && should_fail(&inject_csc_hw_error,
1);
@@ -132,6 +220,26 @@ static void log_gt_err(struct xe_tile *tile, const char
*name, int i, u32 err,
name, severity_str, i, err);
}
+static void log_soc_error(struct xe_tile *tile, const char * const *reg_info,
+ const enum drm_xe_ras_error_severity severity, u32
err_bit, u32 index)
+{
+ const char *severity_str = error_severity[severity];
+ struct xe_device *xe = tile_to_xe(tile);
+ struct xe_drm_ras *ras = &xe->ras;
+ struct xe_drm_ras_counter *info = ras->info[severity];
+ const char *name;
+
+ name = reg_info[err_bit];
+
+ if (strcmp(name, "Undefined")) {
+ if (severity == DRM_XE_RAS_ERROR_SEVERITY_UNCORRECTABLE)
Same comment as last patch.
+ drm_err_ratelimited(&xe->drm, "%s SOC %s detected",
name, severity_str);
+ else
+ drm_warn(&xe->drm, "%s SOC %s detected", name,
severity_str);
+ atomic64_inc(&info[index].counter);
+ }
+}
+
static void gt_hw_error_handler(struct xe_tile *tile, const enum
hardware_error hw_err,
u32 error_id)
{
@@ -210,6 +318,93 @@ static void gt_hw_error_handler(struct xe_tile *tile,
const enum hardware_error
}
}
+static void soc_hw_error_handler(struct xe_tile *tile, const enum hardware_error hw_err,
+ u32 error_id)
+{
+ const enum drm_xe_ras_error_severity severity =
hw_err_to_severity(hw_err);
+ struct xe_device *xe = tile_to_xe(tile);
+ struct xe_mmio *mmio = &tile->mmio;
+ unsigned long master_global_errstat, slave_global_errstat;
+ unsigned long master_local_errstat, slave_local_errstat;
+ u32 base, slave_base, regbit;
+ int i;
+
+ if (xe->info.platform != XE_PVC)
+ return;
+
+ base = SOC_PVC_MASTER_BASE;
'master'?
+ slave_base = SOC_PVC_SLAVE_BASE;
+
+ /* Mask error type in GSYSEVTCTL so that no new errors of the type will
be reported */
+ for (i = 0; i < XE_SOC_NUM_IEH; i++)
+ xe_mmio_write32(mmio, SOC_GSYSEVTCTL_REG(base, slave_base, i),
~REG_BIT(hw_err));
+
+ if (hw_err == HARDWARE_ERROR_CORRECTABLE) {
+ xe_mmio_write32(mmio, SOC_GLOBAL_ERR_STAT_REG(base, hw_err),
REG_GENMASK(31, 0));
+ xe_mmio_write32(mmio, SOC_LOCAL_ERR_STAT_REG(base, hw_err),
REG_GENMASK(31, 0));
+ xe_mmio_write32(mmio, SOC_GLOBAL_ERR_STAT_REG(slave_base,
hw_err),
+ REG_GENMASK(31, 0));
+ xe_mmio_write32(mmio, SOC_LOCAL_ERR_STAT_REG(slave_base,
hw_err),
+ REG_GENMASK(31, 0));
+ goto unmask_gsysevtctl;
+ }
+
+ /*
+ * Read the master global IEH error register if BIT 1 is set then
process
BIT(1)
+ * the slave IEH first. If BIT 0 in global error register is set then
process
BIT(0)
+ * the corresponding local error registers
Punctuations please!
+ */
+ master_global_errstat = xe_mmio_read32(mmio,
SOC_GLOBAL_ERR_STAT_REG(base, hw_err));
+ if (master_global_errstat & SOC_SLAVE_IEH) {
+ slave_global_errstat = xe_mmio_read32(mmio,
+
SOC_GLOBAL_ERR_STAT_REG(slave_base, hw_err));
+ if (slave_global_errstat & SOC_IEH1_LOCAL_ERR_STATUS) {
+ slave_local_errstat = xe_mmio_read32(mmio,
+
SOC_LOCAL_ERR_STAT_REG(slave_base,
+
hw_err));
With long names usually comes the ugly wrapping :(
So let's either try to shorten some of them here or split the condition
into another function for readability.
+ if (hw_err == HARDWARE_ERROR_FATAL) {
So we don't log for other severities?
+ for_each_set_bit(regbit, &slave_local_errstat,
XE_RAS_REG_SIZE)
+ log_soc_error(tile,
pvc_slave_local_fatal_err_reg,
+ severity, regbit,
error_id);
+ }
+
+ xe_mmio_write32(mmio,
SOC_LOCAL_ERR_STAT_REG(slave_base, hw_err),
+ slave_local_errstat);
+ }
+
+ for_each_set_bit(regbit, &slave_global_errstat, XE_RAS_REG_SIZE)
+ log_soc_error(tile, pvc_slave_global_err_reg, severity,
regbit, error_id);
+
+ xe_mmio_write32(mmio, SOC_GLOBAL_ERR_STAT_REG(slave_base,
hw_err),
+ slave_global_errstat);
+ }
+
+ if (master_global_errstat & SOC_IEH0_LOCAL_ERR_STATUS) {
Ditto for split.
Raag
+ master_local_errstat = xe_mmio_read32(mmio,
SOC_LOCAL_ERR_STAT_REG(base, hw_err));
+
+ for_each_set_bit(regbit, &master_local_errstat,
XE_RAS_REG_SIZE) {
+ const char * const *reg_info = (hw_err ==
HARDWARE_ERROR_FATAL) ?
+
pvc_master_local_fatal_err_reg :
+
pvc_master_local_nonfatal_err_reg;
+
+ log_soc_error(tile, reg_info, severity, regbit,
error_id);
+ }
+
+ xe_mmio_write32(mmio, SOC_LOCAL_ERR_STAT_REG(base, hw_err),
master_local_errstat);
+ }
+
+ for_each_set_bit(regbit, &master_global_errstat, XE_RAS_REG_SIZE)
+ log_soc_error(tile, pvc_master_global_err_reg, severity,
regbit, error_id);
+
+ xe_mmio_write32(mmio, SOC_GLOBAL_ERR_STAT_REG(base, hw_err),
master_global_errstat);
+
+unmask_gsysevtctl:
+ for (i = 0; i < XE_SOC_NUM_IEH; i++)
+ xe_mmio_write32(mmio, SOC_GSYSEVTCTL_REG(base, slave_base, i),
+ (DRM_XE_RAS_ERROR_SEVERITY_MAX << 1) + 1);
+}
+
static void hw_error_source_handler(struct xe_tile *tile, const enum
hardware_error hw_err)
{
const enum drm_xe_ras_error_severity severity =
hw_err_to_severity(hw_err);
@@ -263,8 +458,11 @@ static void hw_error_source_handler(struct xe_tile *tile,
const enum hardware_er
"TILE%d reported %s %s, bit[%d] is set\n",
tile->id, name, severity_str, err_bit);
}
+
if (err_bit == XE_GT_ERROR)
gt_hw_error_handler(tile, hw_err, error_id);
+ if (err_bit == XE_SOC_ERROR)
+ soc_hw_error_handler(tile, hw_err, error_id);
}
clear_reg:
--
2.47.1
