Remove the internal DRM client from fbdev emulation. This has been
required when some DRM drivers provided their own fbdev emulation.

This is no longer the case with commit b55f3bbab891 ("drm/{i915, xe}:
Implement fbdev emulation as in-kernel client") from 2024. Now there's
only a single DRM client for fbdev-emulation that fills out the client
callback functions as required.

Signed-off-by: Thomas Zimmermann <[email protected]>
---
 drivers/gpu/drm/drm_fb_helper.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 05803169bed5..845c63ca15b5 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -343,18 +343,6 @@ EXPORT_SYMBOL(drm_fb_helper_unprepare);
 int drm_fb_helper_init(struct drm_device *dev,
                       struct drm_fb_helper *fb_helper)
 {
-       int ret;
-
-       /*
-        * If this is not the generic fbdev client, initialize a drm_client
-        * without callbacks so we can use the modesets.
-        */
-       if (!fb_helper->client.funcs) {
-               ret = drm_client_init(dev, &fb_helper->client, "drm_fb_helper", 
NULL);
-               if (ret)
-                       return ret;
-       }
-
        dev->fb_helper = fb_helper;
 
        return 0;
@@ -437,9 +425,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
        cancel_work_sync(&fb_helper->damage_work);
 
        drm_fb_helper_release_info(fb_helper);
-
-       if (!fb_helper->client.funcs)
-               drm_client_release(&fb_helper->client);
 }
 EXPORT_SYMBOL(drm_fb_helper_fini);
 
-- 
2.52.0

Reply via email to