Hey, Den 2026-02-05 kl. 15:10, skrev Thomas Zimmermann: > Only DRM clients for fbdev emulation invoke fbdev helpers. Hence remove > the empty placeholders for non-fbdev builds, as they are unused. > > Signed-off-by: Thomas Zimmermann <[email protected]> > --- > include/drm/drm_fb_helper.h | 105 ------------------------------------ > 1 file changed, 105 deletions(-) > > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > index 05cca77b7249..15274b8a1d97 100644 > --- a/include/drm/drm_fb_helper.h > +++ b/include/drm/drm_fb_helper.h > @@ -271,111 +271,6 @@ int drm_fb_helper_ioctl(struct fb_info *info, unsigned > int cmd, > > int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper); > int drm_fb_helper_initial_config(struct drm_fb_helper *fb_helper); > -#else > -static inline void drm_fb_helper_prepare(struct drm_device *dev, > - struct drm_fb_helper *helper, > - unsigned int preferred_bpp, > - const struct drm_fb_helper_funcs > *funcs) > -{ > -} > - > -static inline void drm_fb_helper_unprepare(struct drm_fb_helper *fb_helper) > -{ > -} > - > -static inline int drm_fb_helper_init(struct drm_device *dev, > - struct drm_fb_helper *helper) > -{ > - /* So drivers can use it to free the struct */ > - helper->dev = dev; > - dev->fb_helper = helper; > - > - return 0; > -} > - > -static inline void drm_fb_helper_fini(struct drm_fb_helper *helper) > -{ > - if (helper && helper->dev) > - helper->dev->fb_helper = NULL; > -} > - > -static inline int drm_fb_helper_blank(int blank, struct fb_info *info) > -{ > - return 0; > -} > - > -static inline int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > - struct fb_info *info) > -{ > - return 0; > -} > - > -static inline int drm_fb_helper_set_par(struct fb_info *info) > -{ > - return 0; > -} > - > -static inline int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > - struct fb_info *info) > -{ > - return 0; > -} > - > -static inline int > -drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > -{ > - return 0; > -} > - > -static inline void drm_fb_helper_unregister_info(struct drm_fb_helper > *fb_helper) > -{ > -} > - > -static inline void > -drm_fb_helper_fill_info(struct fb_info *info, > - struct drm_fb_helper *fb_helper, > - struct drm_fb_helper_surface_size *sizes) > -{ > -} > - > -static inline int drm_fb_helper_setcmap(struct fb_cmap *cmap, > - struct fb_info *info) > -{ > - return 0; > -} > - > -static inline int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, > - unsigned long arg) > -{ > - return 0; > -} > - > -#ifdef CONFIG_FB_DEFERRED_IO > -static inline void drm_fb_helper_deferred_io(struct fb_info *info, > - struct list_head *pagelist) > -{ > -} > -#endif > - > -static inline void drm_fb_helper_set_suspend(struct drm_fb_helper *fb_helper, > - bool suspend) > -{ > -} > - > -static inline void > -drm_fb_helper_set_suspend_unlocked(struct drm_fb_helper *fb_helper, bool > suspend) > -{ > -} > - > -static inline int drm_fb_helper_hotplug_event(struct drm_fb_helper > *fb_helper) > -{ > - return 0; > -} > - > -static inline int drm_fb_helper_initial_config(struct drm_fb_helper > *fb_helper) > -{ > - return 0; > -} > #endif > > #endif
Reviewed-by: Maarten Lankhorst <[email protected]>
