Hello, On Sat, Feb 07, 2026 at 10:34:21PM +0100, Uwe Kleine-König wrote: > > > @@ -559,7 +554,7 @@ int au1100fb_drv_suspend(struct platform_device *dev, > > > pm_message_t state) > > > clk_disable(fbdev->lcdclk); > > > - memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs)); > > > + memcpy(&fbdev->pm_regs, fbdev->regs, sizeof(struct au1100fb_regs)); > > > > Although memcpy() was used before, isn't this: > > fbdev->pm_regs = *fbdev->regs; > > sufficient and better? > > Probably yes, that's a separate patch then.
Thinking again: this is copying from io memory. So both memcpy and struct assignment might be a bad idea. I'll keep it as is, this driver already occupies me much longer than I intended. Best regards Uwe
signature.asc
Description: PGP signature
