On 05.12.25 08:18, Byungchul Park wrote: > wait_for_completion() can be used at various points in the code and it's > very hard to distinguish wait_for_completion()s between different usages. > Using a single dept_key for all the wait_for_completion()s could trigger > false positive reports. > > Assign unique dept_key to each distinct wait_for_completion() caller to > avoid false positive reports. > > While at it, add a rust helper for wait_for_completion() to avoid build > errors. > > Signed-off-by: Byungchul Park <[email protected]> > --- > include/linux/completion.h | 100 +++++++++++++++++++++++++++++++------ > kernel/sched/completion.c | 60 +++++++++++----------- > rust/helpers/completion.c | 5 ++ > 3 files changed, 120 insertions(+), 45 deletions(-) > ... > diff --git a/rust/helpers/completion.c b/rust/helpers/completion.c > index b2443262a2ae..5bae5e749def 100644 > --- a/rust/helpers/completion.c > +++ b/rust/helpers/completion.c > @@ -6,3 +6,8 @@ void rust_helper_init_completion(struct completion *x) > { > init_completion(x); > } > + > +void rust_helper_wait_for_completion(struct completion *x)
Please add `__rust_helper`: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/rust/helpers/completion.c?h=next-20260213&id=1c7a6f48f7eeb3014584d2fc55fc67f0cbaeef69 Best regards Dirk
