On Mon, Feb 23, 2026 at 04:24:03PM +0200, Yedaya Katsman wrote: > Add driver for Samsung S6E8FCO DSI video mode panel, used in > Xiaomi Mi A3 mobile phone. > > Co-developed-by: Kamil Gołda <[email protected]> > Signed-off-by: Kamil Gołda <[email protected]> > Signed-off-by: Yedaya Katsman <[email protected]> > --- > MAINTAINERS | 1 + > drivers/gpu/drm/panel/Kconfig | 12 ++ > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-samsung-s6e8fco.c | 293 > ++++++++++++++++++++++++++ > 4 files changed, 307 insertions(+)
Please change the subject to follow "drm: panel: foo bar baz". With that in place: Reviewed-by: Dmitry Baryshkov <[email protected]> > > diff --git a/MAINTAINERS b/MAINTAINERS > index > 545d4cf68b9ac27765c7981e668e32cfecf3366b..238b5332eaf0e0cfb9834084e24671ccaee79939 > 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8187,6 +8187,7 @@ DRM DRIVER FOR SAMSUNG S6E8FCO PANELS > M: Yedaya Katsman <[email protected]> > S: Maintained > F: Documentation/devicetree/bindings/display/panel/samsung,s6e8fco.yaml > +F: drivers/gpu/drm/panel/panel-samsung-s6e8fco.c > > DRM DRIVER FOR SAMSUNG SOFEF00 DDIC > M: David Heidelberg <[email protected]> > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index > 7a83804fedca1b688ce6fbe4295ec9009007e693..734640bb3f73c83e9273573aeb720ea1ba20862f > 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -893,6 +893,18 @@ config DRM_PANEL_SAMSUNG_S6E8AA5X01_AMS561RA01 > ~5.6 inch AMOLED display, and the controller is driven by the MIPI > DSI protocol with 4 lanes. > > +config DRM_PANEL_SAMSUNG_S6E8FCO > + tristate "Samsung S6E8FCO DSI video mode panel" > + depends on OF > + depends on BACKLIGHT_CLASS_DEVICE > + select DRM_MIPI_DSI > + select VIDEOMODE_HELPERS > + help > + Say Y or M here if you want to enable support for the Samsung video > + mode panel S6E8FCO. The panel has a 6.09 inch AMOLED display, with > + a resolution of 720x1560. > + Found in the Xiaomi Mi A3 smartphone (xiaomi-laurel). > + > config DRM_PANEL_SAMSUNG_SOFEF00 > tristate "Samsung SOFEF00 DSI panel controller" > depends on OF > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > index > b9562a6fdcb38bfd0dfee9e8c11e16149ada4386..54eca60e5b57328ea94ed7880f4dead981f87fc1 > 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -91,6 +91,7 @@ obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6E88A0_AMS427AP24) += > panel-samsung-s6e88a0-ams4 > obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6E88A0_AMS452EF01) += > panel-samsung-s6e88a0-ams452ef01.o > obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6E8AA0) += panel-samsung-s6e8aa0.o > obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6E8AA5X01_AMS561RA01) += > panel-samsung-s6e8aa5x01-ams561ra01.o > +obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6E8FCO) += panel-samsung-s6e8fco.o > obj-$(CONFIG_DRM_PANEL_SAMSUNG_SOFEF00) += panel-samsung-sofef00.o > obj-$(CONFIG_DRM_PANEL_SEIKO_43WVF1G) += panel-seiko-43wvf1g.o > obj-$(CONFIG_DRM_PANEL_SHARP_LQ079L1SX01) += panel-sharp-lq079l1sx01.o > diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e8fco.c > b/drivers/gpu/drm/panel/panel-samsung-s6e8fco.c > new file mode 100644 > index > 0000000000000000000000000000000000000000..0a1a1c680ee143d2429a6e1ea59a4fdd16b156b4 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-samsung-s6e8fco.c > @@ -0,0 +1,293 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +// Copyright (c) 2025 Kamil Gołda <[email protected]> > +// Generated with linux-mdss-dsi-panel-driver-generator from vendor device > tree: > +// Copyright (c) 2026, The Linux Foundation. All rights reserved. Hmm, so Kamil worked on it before it was written by LF? Are you sure that the year here is correct? > + > + > +static const struct backlight_ops s6e8fco_samsungp_bl_ops = { > + .update_status = s6e8fco_samsungp_bl_update_status, > + .get_brightness = s6e8fco_samsungp_bl_get_brightness, Does it actually return the written value? > +}; > + -- With best wishes Dmitry
