Hi Vladimir, On Wed, 4 Mar 2026 at 19:00, Vladimir Oltean <[email protected]> wrote: > Consumer drivers shouldn't dereference struct phy, not even to get to > its attributes. > > We have phy_get_bus_width() as a precedent for getting the bus_width > attribute, so let's add phy_get_max_link_rate() and use it in DRM and > CAN drivers. > > Signed-off-by: Vladimir Oltean <[email protected]>
Thanks for your patch! > drivers/net/can/rcar/rcar_canfd.c | 2 +- For the Renesas part: Reviewed-by: Geert Uytterhoeven <[email protected]> > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -640,6 +640,12 @@ void phy_set_bus_width(struct phy *phy, int bus_width) > } > EXPORT_SYMBOL_GPL(phy_set_bus_width); > > +u32 phy_get_max_link_rate(struct phy *phy) > +{ > + return phy->attrs.max_link_rate; > +} > +EXPORT_SYMBOL_GPL(phy_get_max_link_rate); Any specific reason you are not making this a simple static inline function, like phy_get_bus_width()? > + > /** > * _of_phy_get() - lookup and obtain a reference to a phy by phandle > * @np: device_node for which to get the phy Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
