Patches 1-4 and 6 are:
Reviewed-by: Iago Toral Quiroga <[email protected]>
Patch 5 looks good too except for one question I had, I might be
missing something though, so let me know if that's the case.
Iago
El mar, 17-02-2026 a las 09:18 -0300, Maíra Canal escribió:
> This series aims to improve the `struct v3d_stats` lifetime
> management.
> The commit fa6a20c87470 ("drm/v3d: Address race-condition between
> per-fd
> GPU stats and fd release") addressed a race-condition between the
> per-fd
> GPU stats and the fd release by clearing `job->file_priv` before the
> V3D
> per-fd structure is freed and assuring that `job->file_priv` exists
> during the per-fd GPU stats updates.
>
> However, this approach introduced a tricky file_priv NULL-ing dance
> with
> the `queue_lock` spinlock. This series aims to address this issue in
> a
> simpler way: converting `v3d_stats` from embedded structs to
> heap-allocated, refcounted objects. This simplifies the code and
> leaves
> `queue_lock` exclusively for job management.
>
> The series also switches to raw seqcount helpers to resolve a lockdep
> annotation issue, fixes missing error handling in
> drm_sched_entity_init(),
> and removes the now-unnecessary dedicated fence_lock.
>
> Best regards,
> - Maíra
>
> ---
> Maíra Canal (2):
> drm/v3d: Handle error from drm_sched_entity_init()
> drm/v3d: Remove dedicated fence_lock
>
> Tvrtko Ursulin (4):
> drm/v3d: Use raw seqcount helpers instead of fighting with
> lockdep
> drm/v3d: Refcount v3d_stats
> drm/v3d: Hold v3d_stats references in each job
> drm/v3d: Attach per-fd reset counters to v3d_stats
>
> drivers/gpu/drm/v3d/v3d_drv.c | 53 +++++++++-------
> drivers/gpu/drm/v3d/v3d_drv.h | 46 +++++++++-----
> drivers/gpu/drm/v3d/v3d_fence.c | 2 +-
> drivers/gpu/drm/v3d/v3d_gem.c | 43 ++++++++-----
> drivers/gpu/drm/v3d/v3d_irq.c | 2 +-
> drivers/gpu/drm/v3d/v3d_sched.c | 133 +++++++++++++++--------------
> ----------
> drivers/gpu/drm/v3d/v3d_submit.c | 6 ++
> drivers/gpu/drm/v3d/v3d_sysfs.c | 2 +-
> 8 files changed, 147 insertions(+), 140 deletions(-)
> ---
> base-commit: 0ef1dcf4c16bb6d90e8fbf7b18f3d76b79fcde9d
> change-id: 20260215-v3d-reset-locking-improv-ffe16c35569b
>
>
