On 3/6/2026 2:50 AM, Sumit Garg wrote: > drivers/firmware/qcom/Kconfig | 8 + > drivers/firmware/qcom/Makefile | 1 + > drivers/firmware/qcom/qcom_pas.c | 295 +++++++++++++++++++++++++
kernel-doc is throwing some warnings in this file which I've listed below. kernel-doc is also throwing warnings in some of the other files touched by this series, but since those are presumably preexisting I didn't bother to mention them. Just want to avoid adding new warnings. > drivers/firmware/qcom/qcom_pas.h | 53 +++++ > include/linux/firmware/qcom/qcom_pas.h | 41 ++++ > 5 files changed, 398 insertions(+) > create mode 100644 drivers/firmware/qcom/qcom_pas.c > create mode 100644 drivers/firmware/qcom/qcom_pas.h > create mode 100644 include/linux/firmware/qcom/qcom_pas.h ... > +/** > + * qcom_pas_mem_setup() - Prepare the memory related to a given peripheral > + * for firmware loading > + * @pas_id: peripheral authentication service id > + * @addr: start address of memory area to prepare > + * @size: size of the memory area to prepare > + * > + * Returns 0 on success. kernel-doc complains: Warning: drivers/firmware/qcom/qcom_pas.c:103 No description found for return value of 'qcom_pas_mem_setup' should use the kernel-doc Return: tag * Return: 0 on success (Returns: is also accepted although not documented) > + */ ... > +/** > + * qcom_scm_pas_auth_and_reset() - Authenticate the given peripheral firmware > + * and reset the remote processor > + * @pas_id: peripheral authentication service id > + * > + * Return 0 on success. hmmm, kernel-doc didn't complain about this one so the script must accept 'Return' without the ":" (but not 'Returns' without the ":"). Suggest changing to Return: to be conformant with the actual documentation: <https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#function-documentation> > + */ > +int qcom_pas_auth_and_reset(u32 pas_id) > +{ > + if (ops_ptr) > + return ops_ptr->auth_and_reset(ops_ptr->dev, pas_id); > + > + return -ENODEV; > +} > +EXPORT_SYMBOL_GPL(qcom_pas_auth_and_reset); ... > +/** > + * qcom_pas_set_remote_state() - Set the remote processor state > + * @state: peripheral state > + * @pas_id: peripheral authentication service id > + * > + * Returns 0 on success. Warning: drivers/firmware/qcom/qcom_pas.c:217 No description found for return value of 'qcom_pas_set_remote_state' > + */ ... > +/** > + * qcom_pas_shutdown() - Shut down the remote processor > + * @pas_id: peripheral authentication service id > + * > + * Returns 0 on success. Warning: drivers/firmware/qcom/qcom_pas.c:232 No description found for return value of 'qcom_pas_shutdown' > + */ ... > +/** > + * qcom_pas_supported() - Check if the peripheral authentication service is > + * available for the given peripheral > + * @pas_id: peripheral authentication service id > + * > + * Returns true if PAS is supported for this peripheral, otherwise false. Warning: drivers/firmware/qcom/qcom_pas.c:248 No description found for return value of 'qcom_pas_supported' > + */ ... > +/** > + * qcom_pas_is_available() - Check for PAS service > + * > + * Returns true on success. Warning: drivers/firmware/qcom/qcom_pas.c:262 No description found for return value of 'qcom_pas_is_available' > + */
