Hi John,
On Tue, Mar 10, 2026 at 06:34:51PM -0700, John Hubbard wrote:
> On 3/9/26 11:24 PM, Cheng-Yang Chou wrote:
> > - name: c"nova",
> > + name: c"nova-drm",
> > desc: c"Nvidia Graphics",
>
> hmm, as long as we are fooling around with names here, I see that
> this should be "NVIDIA Graphics and Compute", really.
>
> Obviously that can be done separately, though.
Ok.
>
> > };
> >
> > -const NOVA_CORE_MODULE_NAME: &CStr = c"NovaCore";
> > +const NOVA_CORE_MODULE_NAME: &CStr = c"nova-core";
> > const AUXILIARY_NAME: &CStr = c"nova-drm";
> >
> > kernel::auxiliary_device_table!(
> > diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova/nova.rs
> > index 8893e58ee0db..1fd454c7e0df 100644
> > --- a/drivers/gpu/drm/nova/nova.rs
> > +++ b/drivers/gpu/drm/nova/nova.rs
> > @@ -10,7 +10,7 @@
> >
> > kernel::module_auxiliary_driver! {
> > type: NovaDriver,
> > - name: "Nova",
> > + name: "nova-drm",
>
> Well, but now it is out of sync with the file name: nova.rs.
>
> You should change both, or neither, I'm thinking.
I think renaming the file to nova_drm.rs would better reflect the
driver's identity now that the module name is nova-drm, making it easier
for readers to associate the source file with the driver.
Would that work for you?
--
Thanks,
Cheng-Yang
