On Mon, Mar 16, 2026 at 07:34:42AM -0700, Rob Clark wrote: > On Mon, Mar 16, 2026 at 7:28 AM Dmitry Baryshkov > <[email protected]> wrote: > > > > On Mon, Mar 16, 2026 at 10:22:44AM +0100, Konrad Dybcio wrote: > > > On 3/14/26 5:14 AM, Alexander Koskovich wrote: > > > > Commit dc220915ddb2 ("drm/msm: Fix GMEM_BASE for gen8") changed the > > > > GMEM_BASE check from adreno_is_a650_family() & adreno_is_a740_family() > > > > to family >= ADRENO_6XX_GEN4. > > > > > > > > This inadvertently excluded A650 (ADRENO_6XX_GEN3), causing it to report > > > > an incorrect GMEM_BASE which results in severe rendering corruption. > > > > > > > > Update check to also include ADRENO_6XX_GEN3 to fix A650. > > > > > > > > Fixes: dc220915ddb2 ("drm/msm: Fix GMEM_BASE for gen8") > > > > > > Hm, that commit also changed the value for A730 - Akhil/Rob, should > > > that be changed back? > > > > I'd say, I'm also surprised about something being broken for A650. Which > > path / stack uses this value? > > Anything that samples from GMEM (gl or vk).. which could include > blend_equation_advanced, custom resolve, etc. > > It's maybe not common enough to immediately notice something wrong, it > depends on your DE. >
Reviewed-by: Dmitry Baryshkov <[email protected]> -- With best wishes Dmitry
