Re: [PATCH 13/15] drm/ast: Gen6: Fix open-coded register access

[Jocelyn Falempe]

On 23/03/2026 16:56, Thomas Zimmermann wrote:

Replace all open-coded access to SCU registers in Gen6 with the
appropriate calls to ast_moutdwm() and ast_mindwm(). Use SCU register
constants. Name variables according to registers.

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfale...@redhat.com>

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
---
  drivers/gpu/drm/ast/ast_2500.c | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/ast/ast_2500.c b/drivers/gpu/drm/ast/ast_2500.c
index 39f401dd1f47..e442cb6a23d9 100644
--- a/drivers/gpu/drm/ast/ast_2500.c
+++ b/drivers/gpu/drm/ast/ast_2500.c
@@ -507,6 +507,8 @@ static void ast_post_chip_2500(struct ast_device *ast)

reg = ast_get_index_reg_mask(ast, AST_IO_VGACRI, 0xd0, 0xff);

        if ((reg & AST_IO_VGACRD0_VRAM_INIT_STATUS_MASK) == 0) {/* vga only */
+               u32 scu008;
+
                /* Clear bus lock condition */
                ast_2500_patch_ahb(ast->regs);

@@ -540,9 +542,9 @@ static void ast_post_chip_2500(struct ast_device *ast)

                        ast_moutdwm(ast, AST_REG_SCU07C, 0x00004000);

/* Slow down CPU/AHB CLK in VGA only mode */

-               temp = ast_read32(ast, 0x12008);
-               temp |= 0x73;
-               ast_write32(ast, 0x12008, temp);
+               scu008 = ast_mindwm(ast, AST_REG_SCU008);
+               scu008 |= 0x00000073;
+               ast_moutdwm(ast, AST_REG_SCU008, scu008);

if (!ast_dram_init_2500(ast))

                        drm_err(dev, "DRAM init failed !\n");