On Tue, Mar 24, 2026 at 11:05 PM Jason-JH Lin <[email protected]> wrote: > > Since the mailbox driver data can be obtained using cmdq_get_mbox_priv() > and all CMDQ users have transitioned to cmdq_get_mbox_priv(), > cmdq_get_shift_pa() can be removed. > > Signed-off-by: Jason-JH Lin <[email protected]> > Reviewed-by: AngeloGioacchino Del Regno > <[email protected]> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 8 -------- > include/linux/mailbox/mtk-cmdq-mailbox.h | 12 ------------ > 2 files changed, 20 deletions(-) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > b/drivers/mailbox/mtk-cmdq-mailbox.c > index d7c6b38888a3..f463f443e834 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -123,14 +123,6 @@ void cmdq_get_mbox_priv(struct mbox_chan *chan, struct > cmdq_mbox_priv *priv) > } > EXPORT_SYMBOL(cmdq_get_mbox_priv); > > -u8 cmdq_get_shift_pa(struct mbox_chan *chan) > -{ > - struct cmdq *cmdq = container_of(chan->mbox, struct cmdq, mbox); > - > - return cmdq->pdata->shift; > -} > -EXPORT_SYMBOL(cmdq_get_shift_pa); > - > static void cmdq_vm_init(struct cmdq *cmdq) > { > int i; > diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h > b/include/linux/mailbox/mtk-cmdq-mailbox.h > index 07c1bfbdb8c4..a42b44d5fd49 100644 > --- a/include/linux/mailbox/mtk-cmdq-mailbox.h > +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h > @@ -96,16 +96,4 @@ struct cmdq_pkt { > */ > void cmdq_get_mbox_priv(struct mbox_chan *chan, struct cmdq_mbox_priv *priv); > > -/** > - * cmdq_get_shift_pa() - get the shift bits of physical address > - * @chan: mailbox channel > - * > - * GCE can only fetch the command buffer address from a 32-bit register. > - * Some SOCs support more than 32-bit command buffer address for GCE, which > - * requires some shift bits to make the address fit into the 32-bit register. > - * > - * Return: the shift bits of physical address > - */ > -u8 cmdq_get_shift_pa(struct mbox_chan *chan); > - > #endif /* __MTK_CMDQ_MAILBOX_H__ */
I think the simplest would be to take this with the other two predecessor patches. Acked-by: Jassi Brar <[email protected]>
