Hello Liu, On Thu Apr 2, 2026 at 6:05 AM CEST, Liu Ying wrote: > Hi Luca, > > On Mon, Mar 30, 2026 at 09:25:49PM +0200, Luca Ceresoli wrote: > > [...] > >> Changes in v2: >> - don't apply the overlay if the SoC is not i.MX8MP >> - build unconditionally, but depend on DRM_IMX_LCDIF >> - remove useless error check >> - add missing cleanup.h and init.h includes, remove unneeded includes >> - avoid dtc warnings on overlay >> - fix typo in Kconfig help text >> - not added the Tested-bys because the code has changed >> - split the 'plat_data->output_port = 1' line to a separate patch > > v2 also changes commit mesg.
Good to see someone looks at the changelog! :) Im updating the v2 changelog in v3 to mention this. >> + return of_overlay_fdt_apply(dtbo_start, dtbo_size, &ovcs_id, NULL); > > Kernel doc of of_overlay_fdt_apply() says: > > * On error return, the changeset may be partially applied. This is > especially > * likely if an OF_OVERLAY_POST_APPLY notifier returns an error. In this case > * the caller should call of_overlay_remove() with the value in *@ret_ovcs_id. > > Need a bailout? Indeed! I mistakenly removed it in v2, re-adding it in v3. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
