Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incorrect Kconfig conditional compilation attribute `#[cfg(CONFIG_KUNIT = "y")]` causes a build failure when KUnit is enabled. --
commit 5c04ae06d96b8f9a5712fdd9c7e8f73f7a3cbf26 Author: Mike Lothian <[email protected]> Add offline KUnit self-tests for the pure protocol builders/parsers and This commit adds offline KUnit self-tests for the pure protocol builders/parsers and the crypto bindings the control plane relies on. The crypto cases use published known-answer vectors and there are tests for EDID extraction and DDC/CI encoding. > diff --git a/drivers/gpu/drm/vino/vino.rs b/drivers/gpu/drm/vino/vino.rs > index ee63ce7e4625..2d22c3f822cd 100644 > --- a/drivers/gpu/drm/vino/vino.rs > +++ b/drivers/gpu/drm/vino/vino.rs [ ... ] > +/// Build a minimal valid 128-byte EDID with a 1920x1080@60 detailed timing > at base-block > +/// offset `dtd_at` (54 = preferred slot), a correct checksum, and the > standard magic. > +#[cfg(CONFIG_KUNIT = "y")] [Severity: Low] Will this configuration attribute work correctly in the kernel's Rust build system? The Kconfig symbols are passed to rustc as boolean configuration flags (e.g., --cfg CONFIG_KUNIT), not as key-value strings. Since #[cfg(CONFIG_KUNIT = "y")] always evaluates to false, the mk_test_edid() function will be stripped from the build. Does this cause a compilation error when KUnit is enabled and the test module attempts to call it? Should this be changed to #[cfg(CONFIG_KUNIT)] instead? > +fn mk_test_edid(dtd_at: usize) -> [u8; 128] { -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=7
