Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] Incorrect `$id` path with extra `bindings/` directory component. - [Low] Undocumented property `enable-gpios` is used in the example but missing from the `properties` block. --
--- Patch [7]: [PATCH 07/16] ASoC: dt-bindings: add TI PCM1773 --- commit 743fe66d5b39db7483986e7887f8d34c7081d440 Author: H. Nikolaus Schaller <[email protected]> ASoC: dt-bindings: add TI PCM1773 This commit adds a new device tree binding for the Texas Instruments PCM1771 and PCM1773 simple audio codecs. It documents the compatible string and shows basic usage. > diff --git a/Documentation/devicetree/bindings/sound/pcm1773.yaml > b/Documentation/devicetree/bindings/sound/pcm1773.yaml > new file mode 100644 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/pcm1773.yaml > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/bindings/sound/pcm1773.yaml# [Severity: Low] Does this $id path match the exact file path relative to Documentation/devicetree/bindings/? It looks like there is an extra bindings/ directory component here which might cause schema cross-reference resolution to fail or dt_binding_check to skip validation. [ ... ] > +properties: > + compatible: > + const: ti,pcm1773 > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + audio-codec { > + compatible = "ti,pcm1773"; > + enable-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>; [Severity: Low] Will this example fail dt_binding_check validation? The schema uses additionalProperties: false, but enable-gpios is omitted from the properties block above, which will cause the strict schema validation to reject this example and any actual device tree nodes using the property. > + }; > + > +... -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=7
