Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The binding schema fails to enforce the required properties for the `ti,twl4030-regen` compatible string and rejects the `startup-delay-us` property. - [Low] The commit message contains misspellings and an incorrect hardware model number. --
--- Patch [1]: [PATCH 01/16] dt-bindings: twl-regulator: Add bindings for exposing ti,twl4030-regen --- commit 47a2b827603c26c697c09f74aba57400724a478c Author: Grond <[email protected]> dt-bindings: twl-regulator: Add bindings for exposing ti,twl4030-regen This commit adds the ti,twl4030-regen compatible string to the bindings. It also updates the commit message to document its newly required regulator properties. > +Reguired properties: > +For twl3040 REGEN signal: [Severity: Low] This isn't a bug, but should "Reguired" be "Required" and "twl3040" be "twl4030"? > diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml > b/Documentation/devicetree/bindings/mfd/ti,twl.yaml > index 9cc3e4721612e..183fc015e40ad 100644 > --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml > +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml > @@ -46,6 +46,7 @@ allOf: > - ti,twl4030-vusb1v5 > - ti,twl4030-vusb1v8 > - ti,twl4030-vusb3v1 > + - ti,twl4030-regen > ti,retain-on-reset: false > > properties: [Severity: Medium] Will this schema allow validation to pass without the properties described in the commit message? Since there is no corresponding if-then block added to enforce regulator-min-microvolt and regulator-max-microvolt, they won't be required for ti,twl4030-regen. Also, does this cause validation to fail when startup-delay-us is used? Because startup-delay-us is not defined in the base regulator schema and unevaluatedProperties is set to false for the regulator pattern block, any device tree attempting to use startup-delay-us as instructed will likely be rejected during dt_binding_check and dtbs_check. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
