On Sat, 11 Jul 2026 13:51:14 +0200, Esben Haabendal <[email protected]> wrote:

Hi Esben,

>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c 
> b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> index e6dbe51d0dba..b11fbeb71229 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> @@ -11,6 +11,8 @@
>   *   = 1x Single-link DSI ~ 2x Single-link or 1x Dual-link LVDS
>   *   - Supported
>   *   - Dual-link LVDS mode tested
> + *   - Single-link to LVDS Channel A tested.
> + *   - Single-link to LVDS Channel B tested.

Small nit: no '.' at the end of the line, as for other lines in this list.

> @@ -904,29 +907,40 @@ static int sn65dsi83_parse_dt(struct sn65dsi83 *ctx, 
> enum sn65dsi83_model model)
> [ ... skip 26 lines ... ]
> -                     ctx->lvds_dual_link_even_odd_swap = true;
> +                     ctx->lvds_dual_link = true;
> +                     ctx->lvds_channel_swap = true;
> +             } else if (port0 && !port1 && port2 && !port3) {
> +                     /* DSI Channel A to LVDS Channel A */
> +                     pr_warn("%s: DSI Channel A to LVDS Channel A\n", 
> __func__);

No readon to warn here. At most a dev_dbg() can fit here, but I'd rather
just print nothing.

Otherwise looks good.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Reply via email to