Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: - [Medium] The overlay configures the ADC input pads for LCD digital signals but fails to disable the `adc0` controller. - [Low] The panel device node is named `lcd-panel`, which violates the standard Device Tree bindings for display panels. - [Low] The overlay disables audio codecs and DAIs but leaves the top-level sound card nodes enabled, causing endless probe deferrals. --
--- Patch [7]: [PATCH v2 7/7] arm64: dts: imx8dxl-evk: add lcdif overlay --- (Note: The format of this report is altered to a free-form summary due to recitation restrictions. No code from the original patch is directly quoted.) commit d5a124bf1de36e3cda648d2a3efe1d55a60da419 Author: Frank Li <[email protected]> arm64: dts: imx8dxl-evk: add lcdif overlay This commit adds support for the waiken,101wx001 lcd panel by introducing a new device tree overlay for the imx8dxl-evk. [Severity: Low] The device node for the display panel in the new overlay is named lcd-panel. Does this violate the standard Device Tree bindings for display panels? According to panel-common.yaml, the generic node name for a display panel should typically just be panel. Using a non-generic name could result in dtbs_check warnings when building the device tree. [Severity: Medium] The pinctrl_lcdif node configures several ADC input pads to act as digital LCD signals. However, the overlay does not appear to disable the corresponding adc0 controller. Will this cause the adc0 controller to probe and expose non-functional IIO channels to userspace, potentially resulting in applications reading meaningless garbage instead of valid analog voltages? [Severity: Low] The overlay disables several audio codecs and DAIs, such as sai0, sai1, and the various wm8960 components, but it leaves the top-level sound card nodes from the base device tree enabled. Could this result in the sound card drivers attempting to probe and failing indefinitely with probe deferrals, leaving dangling devices in the deferred list during system initialization? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=7
