Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The new `min_requested_bpc` property is not printed in `drm_atomic_connector_print_state()`. --
--- Patch [2]: [PATCH v2 2/2] drm/connector: hdmi: Implement "min bpc" property --- commit 1bb247d1cac675bb602431e3c391ddd31f8fed8d Author: Nicolas Frattaroli <[email protected]> drm/connector: hdmi: Implement "min bpc" property Act on the "min bpc" property's min_requested_bpc state in the common HDMI state helpers, and register the property on HDMI connectors. Also add two KUnit tests to verify that the property behaves as expected. > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 3ecc079404a10..f019bd5fef692 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -640,6 +640,10 @@ int drmm_connector_hdmi_init(struct drm_device *dev, > if (ret) > return ret; > > + ret = drm_connector_attach_min_bpc_property(connector, max_bpc); > + if (ret) > + return ret; > + [Severity: Low] Since we are adding support for the min bpc property and using min_requested_bpc in the connector state, should this also be printed in drm_atomic_connector_print_state() alongside max_requested_bpc? For example, looking at drivers/gpu/drm/drm_atomic.c in drm_atomic_connector_print_state(): drm_printf_indent(p, 1, "max_requested_bpc=%d\n", state->max_requested_bpc); drm_printf_indent(p, 1, "colorspace=%s\n", drm_get_colorspace_name(state->colorspace)); Without printing it here, the debugfs atomic state dump will not display the min_requested_bpc field, which might make debugging atomic commits incomplete. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
