Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Unnecessary duplication of clock array and descriptor structures for MSM8952, which are identical to MSM8976. --
commit cc0d394f5055e6be5a5f88b51a807761e8dafacc Author: Muzaffer Kadir <[email protected]> clk: qcom: smd-rpm: Add clocks for MSM8952 This commit adds clock definitions for the MSM8952 platform. The commit message notes that MSM8952 shares the same clocks as MSM8976 and MSM8940. > diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c > --- a/drivers/clk/qcom/clk-smd-rpm.c > +++ b/drivers/clk/qcom/clk-smd-rpm.c > @@ -740,6 +740,34 @@ static const struct rpm_smd_clk_desc rpm_clk_msm8940 = { > .num_icc_clks = ARRAY_SIZE(bimc_pcnoc_snoc_smmnoc_icc_clks), > }; > > +static struct clk_smd_rpm *msm8952_clks[] = { > + [RPM_SMD_XO_CLK_SRC] = &clk_smd_rpm_branch_bi_tcxo, [ ... ] > +static const struct rpm_smd_clk_desc rpm_clk_msm8952 = { > + .clks = msm8952_clks, > + .num_clks = ARRAY_SIZE(msm8952_clks), > + .icc_clks = bimc_pcnoc_snoc_smmnoc_icc_clks, > + .num_icc_clks = ARRAY_SIZE(bimc_pcnoc_snoc_smmnoc_icc_clks), > +}; > + [ ... ] > @@ -1292,6 +1320,7 @@ static const struct of_device_id > rpm_smd_clk_match_table[] = { > { .compatible = "qcom,rpmcc-msm8936", .data = &rpm_clk_msm8936 }, > { .compatible = "qcom,rpmcc-msm8937", .data = &rpm_clk_msm8937 }, > { .compatible = "qcom,rpmcc-msm8940", .data = &rpm_clk_msm8940 }, > + { .compatible = "qcom,rpmcc-msm8952", .data = &rpm_clk_msm8952 }, [Severity: Low] Since the commit message notes that MSM8952 has the exact same clocks as MSM8976, could we avoid duplicating msm8952_clks and rpm_clk_msm8952 by simply reusing the existing rpm_clk_msm8976 descriptor here? Other devices in this driver use this pattern to avoid redundancy, such as qcom,rpmcc-msm8226 which reuses rpm_clk_msm8974. Would setting the data pointer to &rpm_clk_msm8976 work for MSM8952 as well? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20260912-msm8952-initial-support-v1-0-0e742578b...@mainlining.org?part=13
