Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: - [Medium] Hardware Interrupt Polarity: TUSB320 interrupt is configured as IRQ_TYPE_EDGE_RISING, but the INT_N pin is active low / open drain. - [Medium] Hardware GPIO Polarity: SD card detect (cd-gpios) is configured as GPIO_ACTIVE_HIGH. - [Low] DT Binding Violation: tpa6130a2 node uses 'power-gpios' instead of 'power-gpio'. --
commit 3d5d5ba8ff3606c0a6ed8dba09661107776c63ef Author: Muzaffer Kadir <[email protected]> arm64: dts: qcom: generalmobile-shamrock: new device This commit introduces support for the General Mobile Shamrock (GM 5 Plus) device, which is based on the MSM8952 SoC. The design is similar to the L9300 reference board. [1] https://github.com/Asderdd/android_kernel_generalmobile_shamrock/blob/cm-14.1/arch/arm/boot/dts/qcom/msm8952-l9300.dtsi > diff --git a/arch/arm64/boot/dts/qcom/msm8952-generalmobile-shamrock.dts > b/arch/arm64/boot/dts/qcom/msm8952-generalmobile-shamrock.dts > new file mode 100644 > index 0000000000000..22723b62d3d6c > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/msm8952-generalmobile-shamrock.dts [ ... ] > +&blsp2_i2c1 { > + status = "okay"; > + > + /* FUSB301 @25 USB-C Controller */ > + > + tpa6130a2: tpa6130a2@60 { > + compatible = "ti,tpa6130a2"; > + pinctrl-0 = <&tpa6130a2_default>; > + pinctrl-names = "default"; > + reg = <0x60>; > + power-gpios = <&tlmm 61 GPIO_ACTIVE_HIGH>; [Severity: Low] Does this violate the ti,tpa6130a2 device tree binding schema? The schema explicitly expects the singular power-gpio property. Using power-gpios will cause a schema validation error during dtbs_check. > + Vdd-supply = <&pm8950_l22>; > + }; > + > + tusb320: tusb320@67 { > + compatible = "ti,tusb320"; > + reg = <0x67>; > + interrupts-extended = <&tlmm 45 IRQ_TYPE_EDGE_RISING>; [Severity: Medium] Is the interrupt polarity configured correctly for the tusb320 node? The hardware specification indicates the INT_N pin is an open-drain, active-low output. Using IRQ_TYPE_EDGE_RISING might cause the interrupt to deadlock and be missed upon USB plug or unplug events, as the SoC expects a rising edge rather than a falling edge. [ ... ] > +&sdhc_2 { > + cd-gpios = <&tlmm 67 GPIO_ACTIVE_HIGH>; [Severity: Medium] Should the SD card detect cd-gpios be configured as active low? Standard SD slots typically use a normally-open active-low switch that shorts to ground upon insertion. Configuring this as GPIO_ACTIVE_HIGH might result in inverted card detection logic where the OS reports the card as inserted when it is actually empty. > + vmmc-supply = <&pm8950_l11>; > + vqmmc-supply = <&pm8950_l12>; > + > + status = "okay"; > +}; -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20260912-msm8952-initial-support-v1-0-0e742578b...@mainlining.org?part=20
