AMD General Capset ID 7 is already used by VIRCL in the virgl/virtio-gpu stack So ROCm use ID 8, and we have created a pr in spec to reserve the ID8
-----Original Message----- From: [email protected] <[email protected]> Sent: Thursday, September 17, 2026 6:34 PM To: Huang, Honglei1 <[email protected]> Cc: Michael S. Tsirkin <[email protected]>; [email protected]; Eugenio Perez <[email protected]>; [email protected] Subject: Re: [PATCH v6 1/4] drm/virtio-gpu: Add VIRTIO_GPU_CAPSET_ROCM capability Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] uapi: VIRTIO_GPU_CAPSET_ROCM defines unstandardized capset ID 8 -- commit ddbf02d8a1557a4976371db4a94be88bc1f7052f Author: Honglei Huang <[email protected]> drm/virtio-gpu: Add VIRTIO_GPU_CAPSET_ROCM capability This commit adds a new GPU capability set VIRTIO_GPU_CAPSET_ROCM to the virtio gpu UAPI header to support ROCm compute workloads in virtualized environments. > diff --git a/include/uapi/linux/virtio_gpu.h > b/include/uapi/linux/virtio_gpu.h index 4f530d90058c7..3d4dfadc9d789 > 100644 > --- a/include/uapi/linux/virtio_gpu.h > +++ b/include/uapi/linux/virtio_gpu.h > @@ -321,6 +321,7 @@ struct virtio_gpu_cmd_submit { #define > VIRTIO_GPU_CAPSET_VENUS 4 #define VIRTIO_GPU_CAPSET_CROSS_DOMAIN 5 > #define VIRTIO_GPU_CAPSET_DRM 6 > +#define VIRTIO_GPU_CAPSET_ROCM 8 [Severity: Medium] Does allocating this ID without specification standardization risk permanent ABI collisions? If the virtio standard later assigns ID 8 to another capability, this UAPI addition could cause a conflict. Furthermore, skipping ID 7 leaves an undocumented gap that might conflict with virtio standardization protocols. Has ID 8 been allocated in the upstream virtio specification? > > /* VIRTIO_GPU_CMD_GET_CAPSET_INFO */ > struct virtio_gpu_get_capset_info { -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
