Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: gpu: software resource policy in device tree --
commit c9c432471efad1a2abcbaf062de9fa8ddb5708c3 Author: Karunika Choo <[email protected]> dt-bindings: gpu: panthor: Document AW assignment DT property Introduce arm,access-window-mask property to allow partitions to define the assigned access windows at probe time. > diff --git > a/Documentation/devicetree/bindings/gpu/arm,mali-gen5-am-arbitration.yaml > b/Documentation/devicetree/bindings/gpu/arm,mali-gen5-am-arbitration.yaml > index 9ea2b4bb9a344..4e7933829e2be 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-gen5-am-arbitration.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-gen5-am-arbitration.yaml > @@ -52,6 +52,15 @@ patternProperties: > Hardware partition control index. Must identify a partition > present on > the GPU and be unique among this device's partition nodes. > > + arm,access-window-mask: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maximum: 0xffff > + default: 0 > + description: > + Initial access window assignment mask. Bit N selects global > + access window ID N. Masks must be disjoint across partitions. > + If omitted, no access windows are assigned by default. > + [Severity: Low] Does this new property improperly introduce software policy into the hardware description bindings? Encoding dynamic resource assignment with arm,access-window-mask in the device tree dictates software policy rather than describing pure hardware topology. This restricts the kernel's flexibility to dynamically assign resources based on runtime workloads, as it forces an initial hardcoded allocation upon driver probe. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=18
