Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] drm: build failure in armada driver due to missing header rename - [Low] drm: sphinx documentation build fails due to un-updated kernel-doc paths --
commit eec385087eda413784c5684a793dc7987f6f4f49 Author: Thomas Zimmermann <[email protected]> drm/fbdev: Move fbdev helpers into client library This commit moves DRM's fbdev helpers into the client-library module and fixes include statements throughout the DRM drivers. It also renames the files from drm_fb_helper to drm_fbdev_helper. > diff --git a/include/drm/drm_fb_helper.h > b/include/drm/clients/drm_fbdev_helper.h > similarity index 99% > rename from include/drm/drm_fb_helper.h > rename to include/drm/clients/drm_fbdev_helper.h > index 0c5e5ed7b5e74..7575aaf34c620 100644 > --- a/include/drm/drm_fb_helper.h > +++ b/include/drm/clients/drm_fbdev_helper.h [Severity: Low] Does drivers/gpu/drm/armada/armada_fbdev.c need to be updated to include the new header path? This file still includes the old header path, which causes a build failure because the header was renamed: drivers/gpu/drm/armada/armada_fbdev.c: #include <drm/drm_fb_helper.h> [Severity: Low] Do the kernel-doc directives in Documentation/gpu/drm-kms-helpers.rst need to be updated? These directives reference the old file paths, breaking the Sphinx documentation build: Documentation/gpu/drm-kms-helpers.rst: .. kernel-doc:: drivers/gpu/drm/drm_fb_helper.c :doc: fbdev helpers .. kernel-doc:: include/drm/drm_fb_helper.h :internal: .. kernel-doc:: drivers/gpu/drm/drm_fb_helper.c :export: -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
