Hi, On Mon, Sep 28, 2026 at 9:16 AM Arnd Bergmann <[email protected]> wrote: > > From: Arnd Bergmann <[email protected]> > > The devm_drm_of_get_bridge() declaration moved to drm_panel.h, but > not all callers include this, which leads to build failures in > some configurations: > > drivers/gpu/drm/imx/lcdc/imx-lcdc.c: In function 'imx_lcdc_probe': > drivers/gpu/drm/imx/lcdc/imx-lcdc.c:404:18: error: implicit declaration of > function 'devm_drm_of_get_bridge' [-Wimplicit-function-declaration] > 404 | bridge = devm_drm_of_get_bridge(dev, dev->of_node, 0, 0); > | ^~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/verisilicon/vs_bridge.c: In function 'vs_bridge_init': > drivers/gpu/drm/verisilicon/vs_bridge.c:306:16: error: implicit declaration > of function 'devm_drm_of_get_bridge' [-Wimplicit-function-declaration] > 306 | next = devm_drm_of_get_bridge(drm_dev->dev, > drm_dev->dev->of_node, > | ^~~~~~~~~~~~~~~~~~~~~~ > > Include the new header in all files that need it. > > Fixes: aa8a8c7e4641 ("drm/bridge: panel: move all code to drm_panel.c") > Signed-off-by: Arnd Bergmann <[email protected]>
[ ... ] > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c > index e7f9e6d58927..e50737432071 100644 > --- a/drivers/gpu/drm/drm_bridge.c > +++ b/drivers/gpu/drm/drm_bridge.c > @@ -36,6 +36,7 @@ > #include <drm/drm_encoder.h> > #include <drm/drm_file.h> > #include <drm/drm_of.h> > +#include <drm/drm_panel.h> > #include <drm/drm_print.h> > > #include "drm_crtc_internal.h" The above one might not be necessary. drm_bridge.c only references devm_drm_of_get_bridge() in comments. Other than that, this looks OK to me. Reviewed-by: Douglas Anderson <[email protected]> I'll assume Luca will apply the fix since he landed aa8a8c7e4641. -Doug
