Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] rust: macros: non-vertical import formatting in doc tests --
commit b361cafb4eb66d1f226f7d0ead63f4a791967d6c Author: Kaiqi Guo <[email protected]> rust: macros: test exhaustive conversion derives This commit adds extensive tests for From, Into, and TryFrom exhaustive conversion derives. It covers bounded ranges, boolean, full-width primitives, and verifies various compile-time error cases for incomplete domains and invalid layouts. > diff --git a/rust/macros/convert.rs b/rust/macros/convert.rs > index 7fa8a22dc9133..c23b8819572e3 100644 > --- a/rust/macros/convert.rs > +++ b/rust/macros/convert.rs > @@ -1671,3 +1671,375 @@ mod overflow_assert_works_on_unsigned_int {} > /// ``` > mod any_try_from_target_overflow_is_rejected {} > } > + > +mod derive_from_tests { > + /// ``` > + /// use kernel::{macros::{From, Into}, num::Bounded}; [Severity: Low] Does this import (and others in the added doc tests) violate the kernel's vertical import style guidelines? The Rust subsystem guidelines require vertical trailing-comma syntax for imports, but this uses horizontal grouping. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=8
